RFR: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Chris Plummer-2
Sometimes due to the state of the java thread, jstack does cannot determine the address of the java frame and instead it is 0x. We need to special case this so the test does not fail.

-------------

Commit messages:
 - Special case when we can't get the address of the java stack.

Changes: https://git.openjdk.java.net/jdk/pull/2637/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2637&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261929
  Stats: 9 lines in 1 file changed: 4 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2637.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2637/head:pull/2637

PR: https://git.openjdk.java.net/jdk/pull/2637
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Alex Menkov-3
On Fri, 19 Feb 2021 01:04:20 GMT, Chris Plummer <[hidden email]> wrote:

> Sometimes due to the state of the java thread, jstack does cannot determine the address of the java frame and instead it is 0x. We need to special case this so the test does not fail.

Marked as reviewed by amenkov (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2637
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Thomas Stuefe
In reply to this post by Chris Plummer-2
On Fri, 19 Feb 2021 01:04:20 GMT, Chris Plummer <[hidden email]> wrote:

> Sometimes due to the state of the java thread, jstack does cannot determine the address of the java frame and instead it is 0x. We need to special case this so the test does not fail.

LGTM

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2637
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Serguei Spitsyn-2
In reply to this post by Chris Plummer-2
On Fri, 19 Feb 2021 01:04:20 GMT, Chris Plummer <[hidden email]> wrote:

> Sometimes due to the state of the java thread, jstack does cannot determine the address of the java frame and instead it is 0x. We need to special case this so the test does not fail.

LGTM++

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2637
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Chris Plummer-2
On Sat, 20 Feb 2021 10:24:02 GMT, Serguei Spitsyn <[hidden email]> wrote:

>> Sometimes due to the state of the java thread, jstack does cannot determine the address of the java frame and instead it is 0x. We need to special case this so the test does not fail.
>
> LGTM++

Thanks for the reviews!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2637
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Chris Plummer-2
In reply to this post by Chris Plummer-2
On Fri, 19 Feb 2021 01:04:20 GMT, Chris Plummer <[hidden email]> wrote:

> Sometimes due to the state of the java thread, jstack does cannot determine the address of the java frame and instead it is 0x. We need to special case this so the test does not fail.

This pull request has now been integrated.

Changeset: 0825bc55
Author:    Chris Plummer <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/0825bc55
Stats:     9 lines in 1 file changed: 4 ins; 0 del; 5 mod

8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Reviewed-by: amenkov, stuefe, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/2637