RFR: 8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

Calvin Cheung
This to to address a review comment for JDK-8202750:
https://github.com/openjdk/jdk/pull/2581#discussion_r577984793

I forgot to push this change before integration for JDK-8202750.

-------------

Commit messages:
 - 8261939 (initial commit)

Changes: https://git.openjdk.java.net/jdk/pull/2621/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2621&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261939
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2621.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2621/head:pull/2621

PR: https://git.openjdk.java.net/jdk/pull/2621
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

Yumin Qi-3
On Thu, 18 Feb 2021 03:51:47 GMT, Calvin Cheung <[hidden email]> wrote:

> This to to address a review comment for JDK-8202750:
> https://github.com/openjdk/jdk/pull/2581#discussion_r577984793
>
> I forgot to push this change before integration for JDK-8202750.

Looks good and is trivial.

-------------

Marked as reviewed by minqi (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2621
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

Calvin Cheung
In reply to this post by Calvin Cheung
On Thu, 18 Feb 2021 03:51:47 GMT, Calvin Cheung <[hidden email]> wrote:

> This to to address a review comment for JDK-8202750:
> https://github.com/openjdk/jdk/pull/2581#discussion_r577984793
>
> I forgot to push this change before integration for JDK-8202750.

This pull request has now been integrated.

Changeset: b8fd6142
Author:    Calvin Cheung <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/b8fd6142
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

Reviewed-by: minqi

-------------

PR: https://git.openjdk.java.net/jdk/pull/2621