RFR: 8261940: Fix references to IOException in BigDecimal javadoc

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261940: Fix references to IOException in BigDecimal javadoc

Joe Darcy-2
Noticed by some of  Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.

-------------

Commit messages:
 - 8261940: Fix references to IOException in BigDecimal javadoc

Changes: https://git.openjdk.java.net/jdk/pull/2623/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2623&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261940
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2623.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2623/head:pull/2623

PR: https://git.openjdk.java.net/jdk/pull/2623
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261940: Fix references to IOException in BigDecimal javadoc

Alan Bateman-2
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <[hidden email]> wrote:

> Noticed by some of  Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.

Looks okay but it might be simpler to just import java.io.IOException and avoid having two usages of the fully qualified name in the source file.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2623
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261940: Fix references to IOException in BigDecimal javadoc

Chris Hegarty-2
In reply to this post by Joe Darcy-2
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <[hidden email]> wrote:

> Noticed by some of  Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.

Marked as reviewed by chegar (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2623
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261940: Fix references to IOException in BigDecimal javadoc

Iris Clark-4
In reply to this post by Joe Darcy-2
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <[hidden email]> wrote:

> Noticed by some of  Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2623
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261940: Fix references to IOException in BigDecimal javadoc

Brian Burkhalter-3
In reply to this post by Joe Darcy-2
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <[hidden email]> wrote:

> Noticed by some of  Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.

I concur with @AlanBateman about importing `IOException`.

-------------

Marked as reviewed by bpb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2623
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261940: Fix references to IOException in BigDecimal javadoc [v2]

Joe Darcy-2
In reply to this post by Joe Darcy-2
> Noticed by some of  Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.

Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:

  Respond to review feedback.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2623/files
  - new: https://git.openjdk.java.net/jdk/pull/2623/files/27ff1d78..e3a1659f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2623&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2623&range=00-01

  Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2623.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2623/head:pull/2623

PR: https://git.openjdk.java.net/jdk/pull/2623
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261940: Fix references to IOException in BigDecimal javadoc [v2]

Joe Darcy-2
In reply to this post by Brian Burkhalter-3
On Thu, 18 Feb 2021 16:52:19 GMT, Brian Burkhalter <[hidden email]> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Respond to review feedback.
>
> I concur with @AlanBateman about importing `IOException`.

Will integrate using the suggested import of java.io.IOException; thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2623
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261940: Fix references to IOException in BigDecimal javadoc

Joe Darcy-2
In reply to this post by Joe Darcy-2
On Thu, 18 Feb 2021 06:03:41 GMT, Joe Darcy <[hidden email]> wrote:

> Noticed by some of  Jon Gibbons's doc linting & checking tooling, this changeset fixes two javadoc issues for BigDecimal's serialization-related methods, improving the serial form page.

This pull request has now been integrated.

Changeset: c4664e64
Author:    Joe Darcy <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/c4664e64
Stats:     3 lines in 1 file changed: 1 ins; 0 del; 2 mod

8261940: Fix references to IOException in BigDecimal javadoc

Reviewed-by: alanb, chegar, iris, bpb

-------------

PR: https://git.openjdk.java.net/jdk/pull/2623