RFR: 8261973: Shenandoah: Cleanup/simplify root verifier

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8261973: Shenandoah: Cleanup/simplify root verifier

Zhengyu Gu-3
Root processing has gone through significant changes. For example, we used to mark through weak roots when class unloading is off, that is no long the case, OopStorages also simplify roots.

Shenandoah root verifier can be simplified into 2 cases, with/without class unloading.

- [x] hotspot_gc_shenandoah with -XX:+ShenandoahVerify

-------------

Commit messages:
 - update
 - 8261973

Changes: https://git.openjdk.java.net/jdk/pull/2643/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2643&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261973
  Stats: 198 lines in 4 files changed: 10 ins; 159 del; 29 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2643.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2643/head:pull/2643

PR: https://git.openjdk.java.net/jdk/pull/2643
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8261973: Shenandoah: Cleanup/simplify root verifier

Roman Kennke
On Fri, 19 Feb 2021 13:53:26 GMT, Zhengyu Gu <[hidden email]> wrote:

> Root processing has gone through significant changes. For example, we used to mark through weak roots when class unloading is off, that is no long the case, OopStorages also simplify roots.
>
> Shenandoah root verifier can be simplified into 2 cases, with/without class unloading.
>
> - [x] hotspot_gc_shenandoah with -XX:+ShenandoahVerify

Looks good! Thank you!

-------------

Marked as reviewed by rkennke (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2643
Reply | Threaded
Open this post in threaded view
|

Integrated: 8261973: Shenandoah: Cleanup/simplify root verifier

Zhengyu Gu-3
In reply to this post by Zhengyu Gu-3
On Fri, 19 Feb 2021 13:53:26 GMT, Zhengyu Gu <[hidden email]> wrote:

> Root processing has gone through significant changes. For example, we used to mark through weak roots when class unloading is off, that is no long the case, OopStorages also simplify roots.
>
> Shenandoah root verifier can be simplified into 2 cases, with/without class unloading.
>
> - [x] hotspot_gc_shenandoah with -XX:+ShenandoahVerify

This pull request has now been integrated.

Changeset: 7b924d8a
Author:    Zhengyu Gu <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/7b924d8a
Stats:     198 lines in 4 files changed: 10 ins; 159 del; 29 mod

8261973: Shenandoah: Cleanup/simplify root verifier

Reviewed-by: rkennke

-------------

PR: https://git.openjdk.java.net/jdk/pull/2643