RFR: 8262018: Wrong format in SAP copyright header of OsVersionTest

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8262018: Wrong format in SAP copyright header of OsVersionTest

Christoph Langer
The fix for JDK-8261753 introduced a ',' after the copyright years which is not the expected format for SAP copyrights.

-------------

Commit messages:
 - JDK-8262018

Changes: https://git.openjdk.java.net/jdk/pull/2642/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2642&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8262018
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2642.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2642/head:pull/2642

PR: https://git.openjdk.java.net/jdk/pull/2642
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262018: Wrong format in SAP copyright header of OsVersionTest

Martin Doerr
On Fri, 19 Feb 2021 10:35:21 GMT, Christoph Langer <[hidden email]> wrote:

> The fix for JDK-8261753 introduced a ',' after the copyright years which is not the expected format for SAP copyrights.

Seems like this is the only place where we have the wrong comma. Looks good and trivial. Thanks for fixing!

-------------

Marked as reviewed by mdoerr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2642
Reply | Threaded
Open this post in threaded view
|

Integrated: 8262018: Wrong format in SAP copyright header of OsVersionTest

Christoph Langer
In reply to this post by Christoph Langer
On Fri, 19 Feb 2021 10:35:21 GMT, Christoph Langer <[hidden email]> wrote:

> The fix for JDK-8261753 introduced a ',' after the copyright years which is not the expected format for SAP copyrights.

This pull request has now been integrated.

Changeset: efbaedeb
Author:    Christoph Langer <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/efbaedeb
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8262018: Wrong format in SAP copyright header of OsVersionTest

Reviewed-by: mdoerr

-------------

PR: https://git.openjdk.java.net/jdk/pull/2642