RFR: 8262087: Use atomic boolean type in G1FullGCAdjustTask

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8262087: Use atomic boolean type in G1FullGCAdjustTask

Albert Mingkun Yang
Use atomic boolean type to make the intention clear.

-------------

Commit messages:
 - atomic_bool

Changes: https://git.openjdk.java.net/jdk/pull/2664/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2664&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8262087
  Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2664.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2664/head:pull/2664

PR: https://git.openjdk.java.net/jdk/pull/2664
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262087: Use atomic boolean type in G1FullGCAdjustTask

Kim Barrett-2
On Sun, 21 Feb 2021 11:30:52 GMT, Albert Mingkun Yang <[hidden email]> wrote:

> Use atomic boolean type to make the intention clear.

The change looks fine.

I would hope though that in the future this flag will be eliminated and this
can instead invoke parallel reference processing, rather than forcing it to
be done single threaded. Doing anything about that is a task for after Leo's
in-progress work on cleaning up reference processing tasking.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2664
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262087: Use atomic boolean type in G1FullGCAdjustTask

Thomas Schatzl-4
In reply to this post by Albert Mingkun Yang
On Sun, 21 Feb 2021 11:30:52 GMT, Albert Mingkun Yang <[hidden email]> wrote:

> Use atomic boolean type to make the intention clear.

Marked as reviewed by tschatzl (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2664
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262087: Use atomic boolean type in G1FullGCAdjustTask

Albert Mingkun Yang
On Mon, 22 Feb 2021 08:51:32 GMT, Thomas Schatzl <[hidden email]> wrote:

>> Use atomic boolean type to make the intention clear.
>
> Marked as reviewed by tschatzl (Reviewer).

Thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2664
Reply | Threaded
Open this post in threaded view
|

Integrated: 8262087: Use atomic boolean type in G1FullGCAdjustTask

Albert Mingkun Yang
In reply to this post by Albert Mingkun Yang
On Sun, 21 Feb 2021 11:30:52 GMT, Albert Mingkun Yang <[hidden email]> wrote:

> Use atomic boolean type to make the intention clear.

This pull request has now been integrated.

Changeset: 12f6ba0d
Author:    Albert Mingkun Yang <[hidden email]>
Committer: Thomas Schatzl <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/12f6ba0d
Stats:     4 lines in 2 files changed: 0 ins; 1 del; 3 mod

8262087: Use atomic boolean type in G1FullGCAdjustTask

Reviewed-by: kbarrett, tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/2664