RFR: 8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229

Jie Fu-2
Hi all,

This bug was found while I was verifying the fix for JDK-8262096.
It was exposed after JDK-8261229.

Testing:
  - tier1~3 on Linux/x64, no regression

Thanks.
Best regards,
Jie

-------------

Commit messages:
 - 8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229

Changes: https://git.openjdk.java.net/jdk/pull/2668/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2668&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8262097
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2668.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2668/head:pull/2668

PR: https://git.openjdk.java.net/jdk/pull/2668
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229

Igor Veresov-3
On Sun, 21 Feb 2021 23:25:26 GMT, Jie Fu <[hidden email]> wrote:

> Hi all,
>
> This bug was found while I was verifying the fix for JDK-8262096.
> It was exposed after JDK-8261229.
>
> Testing:
>   - tier1~3 on Linux/x64, no regression
>
> Thanks.
> Best regards,
> Jie

I've indirectly fixed this assert that you noticed in JDK-8261225. But I agree, we should apply the client ergonomic settings as well. Looks good.

-------------

Marked as reviewed by iveresov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2668
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229

Vladimir Kozlov-2
In reply to this post by Jie Fu-2
On Sun, 21 Feb 2021 23:25:26 GMT, Jie Fu <[hidden email]> wrote:

> Hi all,
>
> This bug was found while I was verifying the fix for JDK-8262096.
> It was exposed after JDK-8261229.
>
> Testing:
>   - tier1~3 on Linux/x64, no regression
>
> Thanks.
> Best regards,
> Jie

Marked as reviewed by kvn (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2668
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229

Jie Fu-2
In reply to this post by Igor Veresov-3
On Mon, 22 Feb 2021 18:00:57 GMT, Igor Veresov <[hidden email]> wrote:

>> Hi all,
>>
>> This bug was found while I was verifying the fix for JDK-8262096.
>> It was exposed after JDK-8261229.
>>
>> Testing:
>>   - tier1~3 on Linux/x64, no regression
>>
>> Thanks.
>> Best regards,
>> Jie
>
> I've indirectly fixed this assert that you noticed in JDK-8261225. But I agree, we should apply the client ergonomic settings as well. Looks good.

Thanks @veresov and @vnkozlov for your review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2668
Reply | Threaded
Open this post in threaded view
|

Integrated: 8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229

Jie Fu-2
In reply to this post by Jie Fu-2
On Sun, 21 Feb 2021 23:25:26 GMT, Jie Fu <[hidden email]> wrote:

> Hi all,
>
> This bug was found while I was verifying the fix for JDK-8262096.
> It was exposed after JDK-8261229.
>
> Testing:
>   - tier1~3 on Linux/x64, no regression
>
> Thanks.
> Best regards,
> Jie

This pull request has now been integrated.

Changeset: f2bde05e
Author:    Jie Fu <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/f2bde05e
Stats:     2 lines in 1 file changed: 2 ins; 0 del; 0 mod

8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229

Reviewed-by: iveresov, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/2668