RFR: 8262280: Incorrect exception handling for VMThread in class redefinition

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8262280: Incorrect exception handling for VMThread in class redefinition

Coleen Phillimore-3
This is a trivial change to remove the last TRAPS from redefine_single_class which is called by the VM thread during a safepoint.
Tested with serviceability/jvmti/RedefineClasses, vmTestbase/nsk/jvmti,jdi and jdk/java/lang/instrument tests.  And tier1 sanity in progress.

-------------

Commit messages:
 - 8262280: Incorrect exception handling for VMThread in class redefinition

Changes: https://git.openjdk.java.net/jdk/pull/3310/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3310&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8262280
  Stats: 19 lines in 2 files changed: 0 ins; 0 del; 19 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3310.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3310/head:pull/3310

PR: https://git.openjdk.java.net/jdk/pull/3310
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262280: Incorrect exception handling for VMThread in class redefinition

Harold Seigel-2
On Thu, 1 Apr 2021 16:58:00 GMT, Coleen Phillimore <[hidden email]> wrote:

> This is a trivial change to remove the last TRAPS from redefine_single_class which is called by the VM thread during a safepoint.
> Tested with serviceability/jvmti/RedefineClasses, vmTestbase/nsk/jvmti,jdi and jdk/java/lang/instrument tests.  And tier1 sanity in progress.

The changes look good and trivial.
Thank! Harold

-------------

Marked as reviewed by hseigel (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3310
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262280: Incorrect exception handling for VMThread in class redefinition

Coleen Phillimore-3
On Fri, 2 Apr 2021 12:58:18 GMT, Harold Seigel <[hidden email]> wrote:

>> This is a trivial change to remove the last TRAPS from redefine_single_class which is called by the VM thread during a safepoint.
>> Tested with serviceability/jvmti/RedefineClasses, vmTestbase/nsk/jvmti,jdi and jdk/java/lang/instrument tests.  And tier1 sanity in progress.
>
> The changes look good and trivial.
> Thank! Harold

Thanks Harold!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3310
Reply | Threaded
Open this post in threaded view
|

Integrated: 8262280: Incorrect exception handling for VMThread in class redefinition

Coleen Phillimore-3
In reply to this post by Coleen Phillimore-3
On Thu, 1 Apr 2021 16:58:00 GMT, Coleen Phillimore <[hidden email]> wrote:

> This is a trivial change to remove the last TRAPS from redefine_single_class which is called by the VM thread during a safepoint.
> Tested with serviceability/jvmti/RedefineClasses, vmTestbase/nsk/jvmti,jdi and jdk/java/lang/instrument tests.  And tier1 sanity in progress.

This pull request has now been integrated.

Changeset: 885916ed
Author:    Coleen Phillimore <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/885916ed
Stats:     19 lines in 2 files changed: 0 ins; 0 del; 19 mod

8262280: Incorrect exception handling for VMThread in class redefinition

Reviewed-by: hseigel

-------------

PR: https://git.openjdk.java.net/jdk/pull/3310