RFR: 8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

Michael McMahon-4
Hi,

Could I get the following small test fix reviewed please? The test is timing out on Mac probably because it is running on a system with a proxy that is not bypassed for loopback connections. The test already sets NO_PROXY explicitly for one part of the test. It needs to do the equivalent for the second part.

Thanks,
Michael

-------------

Commit messages:
 - Fix for test

Changes: https://git.openjdk.java.net/jdk/pull/3358/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3358&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8262898
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3358.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3358/head:pull/3358

PR: https://git.openjdk.java.net/jdk/pull/3358
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

Daniel Fuchs-2
On Tue, 6 Apr 2021 15:17:53 GMT, Michael McMahon <[hidden email]> wrote:

> Hi,
>
> Could I get the following small test fix reviewed please? The test is timing out on Mac probably because it is running on a system with a proxy that is not bypassed for loopback connections. The test already sets NO_PROXY explicitly for one part of the test. It needs to do the equivalent for the second part.
>
> Thanks,
> Michael

LGTM

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3358
Reply | Threaded
Open this post in threaded view
|

Integrated: 8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

Michael McMahon-4
In reply to this post by Michael McMahon-4
On Tue, 6 Apr 2021 15:17:53 GMT, Michael McMahon <[hidden email]> wrote:

> Hi,
>
> Could I get the following small test fix reviewed please? The test is timing out on Mac probably because it is running on a system with a proxy that is not bypassed for loopback connections. The test already sets NO_PROXY explicitly for one part of the test. It needs to do the equivalent for the second part.
>
> Thanks,
> Michael

This pull request has now been integrated.

Changeset: 4bb80f37
Author:    Michael McMahon <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/4bb80f37
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8262898: com/sun/net/httpserver/bugs/8199849/ParamTest.java times out

Reviewed-by: dfuchs

-------------

PR: https://git.openjdk.java.net/jdk/pull/3358