RFR: 8263097: Update JMH devkit to 1.28

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8263097: Update JMH devkit to 1.28

Claes Redestad-2
Currently at 1.26, so there are a few good improvements and a few bug fixes - notably resolving a build reproducibility issue.

-------------

Commit messages:
 - Update JMH devkit to 1.28

Changes: https://git.openjdk.java.net/jdk/pull/2848/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2848&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263097
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2848.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2848/head:pull/2848

PR: https://git.openjdk.java.net/jdk/pull/2848
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263097: Update JMH devkit to 1.28

Eric Caspole-2
On Fri, 5 Mar 2021 16:04:49 GMT, Claes Redestad <[hidden email]> wrote:

> Currently at 1.26, so there are a few good improvements and a few bug fixes - notably resolving a build reproducibility issue.

Good!
Eric

-------------

Marked as reviewed by ecaspole (Committer).

PR: https://git.openjdk.java.net/jdk/pull/2848
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263097: Update JMH devkit to 1.28

Erik Joelsson-2
On Fri, 5 Mar 2021 16:11:38 GMT, Eric Caspole <[hidden email]> wrote:

>> Currently at 1.26, so there are a few good improvements and a few bug fixes - notably resolving a build reproducibility issue.
>
> Good!
> Eric

Should also updated jib-profiles.js Oracle builds get the new version.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2848
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

Claes Redestad-2
In reply to this post by Claes Redestad-2
> Currently at 1.26, so there are a few good improvements and a few bug fixes - notably resolving a build reproducibility issue.

Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:

  Keep jib-profiles in sync

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2848/files
  - new: https://git.openjdk.java.net/jdk/pull/2848/files/bd98cf7f..c8231877

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2848&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2848&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2848.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2848/head:pull/2848

PR: https://git.openjdk.java.net/jdk/pull/2848
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

Claes Redestad-2
In reply to this post by Erik Joelsson-2
On Fri, 5 Mar 2021 17:25:02 GMT, Erik Joelsson <[hidden email]> wrote:

>> Good!
>> Eric
>
> Should also updated jib-profiles.js Oracle builds get the new version.

Uploaded and verified jib picks up the new version.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2848
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

Erik Joelsson-2
In reply to this post by Claes Redestad-2
On Fri, 5 Mar 2021 19:25:26 GMT, Claes Redestad <[hidden email]> wrote:

>> Currently at 1.26, so there are a few good improvements and a few bug fixes - notably resolving a build reproducibility issue.
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>
>   Keep jib-profiles in sync

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2848
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

Claes Redestad-2
On Mon, 8 Mar 2021 14:18:27 GMT, Erik Joelsson <[hidden email]> wrote:

>> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Keep jib-profiles in sync
>
> Marked as reviewed by erikj (Reviewer).

Thank you for reviewing, Eric and Erik!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2848
Reply | Threaded
Open this post in threaded view
|

Integrated: 8263097: Update JMH devkit to 1.28

Claes Redestad-2
In reply to this post by Claes Redestad-2
On Fri, 5 Mar 2021 16:04:49 GMT, Claes Redestad <[hidden email]> wrote:

> Currently at 1.26, so there are a few good improvements and a few bug fixes - notably resolving a build reproducibility issue.

This pull request has now been integrated.

Changeset: 679faa69
Author:    Claes Redestad <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/679faa69
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

8263097: Update JMH devkit to 1.28

Reviewed-by: ecaspole, erikj

-------------

PR: https://git.openjdk.java.net/jdk/pull/2848