RFR: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

Phil Race
This seems to be a code path that has has not been exercised.
We need to check for null values in the array.

-------------

Commit messages:
 - 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

Changes: https://git.openjdk.java.net/jdk/pull/3055/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3055&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263439
  Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3055.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3055/head:pull/3055

PR: https://git.openjdk.java.net/jdk/pull/3055
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

Prasanta Sadhukhan-2
On Wed, 17 Mar 2021 19:25:50 GMT, Phil Race <[hidden email]> wrote:

> This seems to be a code path that has has not been exercised.
> We need to check for null values in the array.

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3055
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute [v2]

Phil Race
In reply to this post by Phil Race
> This seems to be a code path that has has not been exercised.
> We need to check for null values in the array.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3055/files
  - new: https://git.openjdk.java.net/jdk/pull/3055/files/c7b30e53..f333515f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3055&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3055&range=00-01

  Stats: 64 lines in 1 file changed: 64 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3055.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3055/head:pull/3055

PR: https://git.openjdk.java.net/jdk/pull/3055
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute [v2]

Alexander Zvegintsev-2
On Thu, 18 Mar 2021 17:30:06 GMT, Phil Race <[hidden email]> wrote:

>> This seems to be a code path that has has not been exercised.
>> We need to check for null values in the array.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>
>   8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

Marked as reviewed by azvegint (Reviewer).

src/java.desktop/unix/classes/sun/print/IPPPrintService.java line 572:

> 570:                             (new ExtFinishing(100)).getAll();
> 571:                         for (int j=0; j<fAll.length; j++) {
> 572:                             if (fAll[j] == null) {

Are we still insisting on copyright's year update?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3055
Reply | Threaded
Open this post in threaded view
|

Integrated: 8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

Phil Race
In reply to this post by Phil Race
On Wed, 17 Mar 2021 19:25:50 GMT, Phil Race <[hidden email]> wrote:

> This seems to be a code path that has has not been exercised.
> We need to check for null values in the array.

This pull request has now been integrated.

Changeset: 2173fedd
Author:    Phil Race <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/2173fedd
Stats:     67 lines in 2 files changed: 67 ins; 0 del; 0 mod

8263439: getSupportedAttributeValues() throws NPE for Finishings attribute

Reviewed-by: psadhukhan, azvegint

-------------

PR: https://git.openjdk.java.net/jdk/pull/3055