RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Yumin Qi-3
Hi, Please review

  JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.

Thanks
Yumin

-------------

Commit messages:
 - 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Changes: https://git.openjdk.java.net/jdk/pull/2946/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2946&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263465
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2946.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2946/head:pull/2946

PR: https://git.openjdk.java.net/jdk/pull/2946
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Ioi Lam-2
On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi <[hidden email]> wrote:

> Hi, Please review
>
>   JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.
>
> Thanks
> Yumin

LGTM

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2946
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Daniel D.Daugherty
In reply to this post by Yumin Qi-3
On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi <[hidden email]> wrote:

> Hi, Please review
>
>   JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.
>
> Thanks
> Yumin

Looks good to me.
This change can be integrated until the trivial fix rules.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2946
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Yumin Qi-3
In reply to this post by Ioi Lam-2
On Thu, 11 Mar 2021 18:42:53 GMT, Ioi Lam <[hidden email]> wrote:

>> Hi, Please review
>>
>>   JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.
>>
>> Thanks
>> Yumin
>
> LGTM

Thanks to @iklam @erikj79 @dcubed-ojdk !

-------------

PR: https://git.openjdk.java.net/jdk/pull/2946
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Erik Joelsson-2
In reply to this post by Yumin Qi-3
On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi <[hidden email]> wrote:

> Hi, Please review
>
>   JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.
>
> Thanks
> Yumin

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2946
Reply | Threaded
Open this post in threaded view
|

Integrated: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Yumin Qi-3
In reply to this post by Yumin Qi-3
On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi <[hidden email]> wrote:

> Hi, Please review
>
>   JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.
>
> Thanks
> Yumin

This pull request has now been integrated.

Changeset: 15daccac
Author:    Yumin Qi <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/15daccac
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Reviewed-by: iklam, erikj, dcubed

-------------

PR: https://git.openjdk.java.net/jdk/pull/2946
Reply | Threaded
Open this post in threaded view
|

Re: Integrated: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Magnus Ihse Bursie
Hi Yumin,

While this fix corrected the actual problem, the end result is that the
checking message went from slightly misleading to outright wrong.

Instead of
AC_MSG_CHECKING([if CDS archive is available]) it should read like this:

AC_MSG_CHECKING([if CDS region alignment is available]) Can you please
fix this in a follow-up bug? (And while you are at it, please change
"cds" to "CDS" in the other messages; we are using the capitalized
version of this acronym everywhere else in messages directed to the user.)

/Magnus

On 2021-03-11 20:00, Yumin Qi wrote:

> On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi <[hidden email]> wrote:
>
>> Hi, Please review
>>
>>    JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.
>>
>> Thanks
>> Yumin
> This pull request has now been integrated.
>
> Changeset: 15daccac
> Author:    Yumin Qi <[hidden email]>
> URL:       https://git.openjdk.java.net/jdk/commit/15daccac
> Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod
>
> 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64
>
> Reviewed-by: iklam, erikj, dcubed
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/2946

Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Yumin Qi-3
In reply to this post by Yumin Qi-3
On Thu, 11 Mar 2021 18:46:21 GMT, Yumin Qi <[hidden email]> wrote:

>> LGTM
>
> Thanks to @iklam @erikj79 @dcubed-ojdk !

> _Mailing list message from [Magnus Ihse Bursie](mailto:[hidden email]) on [build-dev](mailto:[hidden email]):_
>
> Hi Yumin,
>
> While this fix corrected the actual problem, the end result is that the
> checking message went from slightly misleading to outright wrong.
>
> Instead of
> AC_MSG_CHECKING([if CDS archive is available]) it should read like this:
>
> AC_MSG_CHECKING([if CDS region alignment is available]) Can you please
> fix this in a follow-up bug? (And while you are at it, please change
> "cds" to "CDS" in the other messages; we are using the capitalized
> version of this acronym everywhere else in messages directed to the user.)
>
> /Magnus
>
> On 2021-03-11 20:00, Yumin Qi wrote:

Got it, will do next. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2946