RFR: 8263488: Verify CWarningWindow works with metal rendering pipeline

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8263488: Verify CWarningWindow works with metal rendering pipeline

Ajit Ghaisas-2
Root cause :
CWarningWindow creates a MTLLayer with null peer.
In MTLLayer.replaceSurfaceData() method, insets should be set only if peer is not null.

Fix :
Added the required null check.

-------------

Commit messages:
 - set native insets only if peer is not null

Changes: https://git.openjdk.java.net/jdk/pull/3086/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3086&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263488
  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3086.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3086/head:pull/3086

PR: https://git.openjdk.java.net/jdk/pull/3086
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263488: Verify CWarningWindow works with metal rendering pipeline

Sergey Bylokhov-2
On Fri, 19 Mar 2021 10:17:57 GMT, Ajit Ghaisas <[hidden email]> wrote:

> Root cause :
> CWarningWindow creates a MTLLayer with null peer.
> In MTLLayer.replaceSurfaceData() method, insets should be set only if peer is not null.
>
> Fix :
> Added the required null check.

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3086
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263488: Verify CWarningWindow works with metal rendering pipeline

Pankaj Bansal-2
In reply to this post by Ajit Ghaisas-2
On Fri, 19 Mar 2021 10:17:57 GMT, Ajit Ghaisas <[hidden email]> wrote:

> Root cause :
> CWarningWindow creates a MTLLayer with null peer.
> In MTLLayer.replaceSurfaceData() method, insets should be set only if peer is not null.
>
> Fix :
> Added the required null check.

Marked as reviewed by pbansal (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3086
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263488: Verify CWarningWindow works with metal rendering pipeline

Alexey Ushakov-3
In reply to this post by Ajit Ghaisas-2
On Fri, 19 Mar 2021 10:17:57 GMT, Ajit Ghaisas <[hidden email]> wrote:

> Root cause :
> CWarningWindow creates a MTLLayer with null peer.
> In MTLLayer.replaceSurfaceData() method, insets should be set only if peer is not null.
>
> Fix :
> Added the required null check.

Marked as reviewed by avu (no project role).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3086
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263488: Verify CWarningWindow works with metal rendering pipeline

Alexander Zuev-3
In reply to this post by Ajit Ghaisas-2
On Fri, 19 Mar 2021 10:17:57 GMT, Ajit Ghaisas <[hidden email]> wrote:

> Root cause :
> CWarningWindow creates a MTLLayer with null peer.
> In MTLLayer.replaceSurfaceData() method, insets should be set only if peer is not null.
>
> Fix :
> Added the required null check.

Marked as reviewed by kizune (Reviewer).

Marked as reviewed by kizune (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3086
Reply | Threaded
Open this post in threaded view
|

Integrated: 8263488: Verify CWarningWindow works with metal rendering pipeline

Ajit Ghaisas-2
In reply to this post by Ajit Ghaisas-2
On Fri, 19 Mar 2021 10:17:57 GMT, Ajit Ghaisas <[hidden email]> wrote:

> Root cause :
> CWarningWindow creates a MTLLayer with null peer.
> In MTLLayer.replaceSurfaceData() method, insets should be set only if peer is not null.
>
> Fix :
> Added the required null check.

This pull request has now been integrated.

Changeset: 42104e55
Author:    Ajit Ghaisas <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/42104e55
Stats:     4 lines in 1 file changed: 2 ins; 0 del; 2 mod

8263488: Verify CWarningWindow works with metal rendering pipeline

Reviewed-by: serb, pbansal, avu, kizune

-------------

PR: https://git.openjdk.java.net/jdk/pull/3086