RFR: 8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer

Pavel Rappo-3
Please review this trivial change. Note that the change is not accompanied by a dedicated test. I don't think such a test would be warranted.

-------------

Commit messages:
 - fix

Changes: https://git.openjdk.java.net/jdk/pull/3034/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3034&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263688
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3034.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3034/head:pull/3034

PR: https://git.openjdk.java.net/jdk/pull/3034
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer

Vicente Romero-3
On Tue, 16 Mar 2021 16:37:51 GMT, Pavel Rappo <[hidden email]> wrote:

> Please review this trivial change. Note that the change is not accompanied by a dedicated test. I don't think such a test would be warranted.

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3034
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer

Pavel Rappo-3
On Tue, 16 Mar 2021 17:06:25 GMT, Vicente Romero <[hidden email]> wrote:

>> Please review this trivial change. Note that the change is not accompanied by a dedicated test. I don't think such a test would be warranted.
>
> lgtm

@vicente-romero-oracle thanks for reviewing this. I note that although that class could be promoted to a record, it should be done separately when mass-retrofitting compiler code with newer language features.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3034
Reply | Threaded
Open this post in threaded view
|

Integrated: 8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer

Pavel Rappo-3
In reply to this post by Pavel Rappo-3
On Tue, 16 Mar 2021 16:37:51 GMT, Pavel Rappo <[hidden email]> wrote:

> Please review this trivial change. Note that the change is not accompanied by a dedicated test. I don't think such a test would be warranted.

This pull request has now been integrated.

Changeset: 23fc2a4d
Author:    Pavel Rappo <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/23fc2a4d
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8263688: Coordinate equals, hashCode and compareTo of JavacFileManager.PathAndContainer

Reviewed-by: vromero

-------------

PR: https://git.openjdk.java.net/jdk/pull/3034