RFR: 8264178: Unused method Threads::nmethods_do

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264178: Unused method Threads::nmethods_do

Albert Mingkun Yang
Trivial change of removing an unused method.

-------------

Commit messages:
 - thread

Changes: https://git.openjdk.java.net/jdk/pull/3199/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3199&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264178
  Stats: 14 lines in 2 files changed: 0 ins; 14 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3199.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3199/head:pull/3199

PR: https://git.openjdk.java.net/jdk/pull/3199
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264178: Unused method Threads::nmethods_do

Coleen Phillimore-3
On Thu, 25 Mar 2021 16:28:53 GMT, Albert Mingkun Yang <[hidden email]> wrote:

> Trivial change of removing an unused method.

Looks good to me.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3199
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264178: Unused method Threads::nmethods_do

David Holmes-2
In reply to this post by Albert Mingkun Yang
On Thu, 25 Mar 2021 16:28:53 GMT, Albert Mingkun Yang <[hidden email]> wrote:

> Trivial change of removing an unused method.

Well spotted. This was missed by another cleanup under JDK-8244658.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3199
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264178: Unused method Threads::nmethods_do

Albert Mingkun Yang
On Fri, 26 Mar 2021 03:40:46 GMT, David Holmes <[hidden email]> wrote:

>> Trivial change of removing an unused method.
>
> Well spotted. This was missed by another cleanup under JDK-8244658.
>
> Thanks,
> David

Thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3199
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264178: Unused method Threads::nmethods_do

Albert Mingkun Yang
In reply to this post by Albert Mingkun Yang
On Thu, 25 Mar 2021 16:28:53 GMT, Albert Mingkun Yang <[hidden email]> wrote:

> Trivial change of removing an unused method.

This pull request has now been integrated.

Changeset: 3a28dc82
Author:    Albert Mingkun Yang <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/3a28dc82
Stats:     14 lines in 2 files changed: 0 ins; 14 del; 0 mod

8264178: Unused method Threads::nmethods_do

Reviewed-by: coleenp, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/3199