RFR: 8264306: Non deterministic generation of java/lang/invoke/MemberName.class

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264306: Non deterministic generation of java/lang/invoke/MemberName.class

Jan Lahoda-3
When hoisting binding variables to the outer scope, we should use `LinkedHashMap` instead of `HashMap`, so that `javac` produces reproducible classfiles.

-------------

Commit messages:
 - 8264306: Non deterministic generation of java/lang/invoke/MemberName.class

Changes: https://git.openjdk.java.net/jdk/pull/3257/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3257&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264306
  Stats: 121 lines in 2 files changed: 119 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3257.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3257/head:pull/3257

PR: https://git.openjdk.java.net/jdk/pull/3257
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264306: Non deterministic generation of java/lang/invoke/MemberName.class

Aleksey Shipilev-5
On Tue, 30 Mar 2021 06:19:22 GMT, Jan Lahoda <[hidden email]> wrote:

> When hoisting binding variables to the outer scope, we should use `LinkedHashMap` instead of `HashMap`, so that `javac` produces reproducible classfiles.

This makes sense to me (and it looks trivial).

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3257
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264306: Non deterministic generation of java/lang/invoke/MemberName.class

Joel Borggrén-Franck-3
In reply to this post by Jan Lahoda-3
On Tue, 30 Mar 2021 06:19:22 GMT, Jan Lahoda <[hidden email]> wrote:

> When hoisting binding variables to the outer scope, we should use `LinkedHashMap` instead of `HashMap`, so that `javac` produces reproducible classfiles.

Marked as reviewed by jfranck (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3257
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264306: Non deterministic generation of java/lang/invoke/MemberName.class

Jan Lahoda-3
In reply to this post by Jan Lahoda-3
On Tue, 30 Mar 2021 06:19:22 GMT, Jan Lahoda <[hidden email]> wrote:

> When hoisting binding variables to the outer scope, we should use `LinkedHashMap` instead of `HashMap`, so that `javac` produces reproducible classfiles.

This pull request has now been integrated.

Changeset: fdfa1dda
Author:    Jan Lahoda <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/fdfa1dda
Stats:     121 lines in 2 files changed: 119 ins; 1 del; 1 mod

8264306: Non deterministic generation of java/lang/invoke/MemberName.class

Reviewed-by: shade, jfranck

-------------

PR: https://git.openjdk.java.net/jdk/pull/3257