RFR: 8264331: Use the blessed modifier order in jdk.compiler

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264331: Use the blessed modifier order in jdk.compiler

Alex Blewitt-2
8264331: Use the blessed modifier order in jdk.compiler

-------------

Commit messages:
 - 8264331: Use the blessed modifier order in jdk.compiler

Changes: https://git.openjdk.java.net/jdk/pull/3235/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3235&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264331
  Stats: 108 lines in 34 files changed: 0 ins; 0 del; 108 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3235.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3235/head:pull/3235

PR: https://git.openjdk.java.net/jdk/pull/3235
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264331: Use the blessed modifier order in jdk.compiler

Alex Blewitt-2
On Sun, 28 Mar 2021 13:55:30 GMT, Alex Blewitt <[hidden email]> wrote:

> 8264331: Use the blessed modifier order in jdk.compiler

Would anyone mind reviewing this change, please? It swaps the order of "final static" for "static final" across a bunch of files.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3235
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264331: Use the blessed modifier order in jdk.compiler

Vicente Romero-3
In reply to this post by Alex Blewitt-2
On Sun, 28 Mar 2021 13:55:30 GMT, Alex Blewitt <[hidden email]> wrote:

> 8264331: Use the blessed modifier order in jdk.compiler

looks good

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3235
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264331: Use the blessed modifier order in jdk.compiler

Iris Clark-4
In reply to this post by Alex Blewitt-2
On Sun, 28 Mar 2021 13:55:30 GMT, Alex Blewitt <[hidden email]> wrote:

> 8264331: Use the blessed modifier order in jdk.compiler

Marked as reviewed by iris (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3235
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264331: Use the blessed modifier order in jdk.compiler

Aleksey Shipilev-5
In reply to this post by Alex Blewitt-2
On Sun, 28 Mar 2021 13:55:30 GMT, Alex Blewitt <[hidden email]> wrote:

> 8264331: Use the blessed modifier order in jdk.compiler

Marked as reviewed by shade (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3235
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264331: Use the blessed modifier order in jdk.compiler

Alex Blewitt-2
In reply to this post by Alex Blewitt-2
On Sun, 28 Mar 2021 13:55:30 GMT, Alex Blewitt <[hidden email]> wrote:

> 8264331: Use the blessed modifier order in jdk.compiler

This pull request has now been integrated.

Changeset: d2df9a7d
Author:    Alex Blewitt <[hidden email]>
Committer: Aleksey Shipilev <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/d2df9a7d
Stats:     108 lines in 34 files changed: 0 ins; 0 del; 108 mod

8264331: Use the blessed modifier order in jdk.compiler

Reviewed-by: vromero, iris, shade

-------------

PR: https://git.openjdk.java.net/jdk/pull/3235