RFR: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested

Nils Eliasson-2
DebugNonSafepoints should be set when PrintAssembly is requested. This only happened for compile commands but not for compiler directives. This PR moves the check to compiler directives - that code path is used for both directives and commands. I am leaving the check and update in arguments.cpp - there might be some need for using flag PrintAssembly for stubs or wrappers, in a code path that doesn't use commands or directives.

-------------

Commit messages:
 - Remove update from compilerOracle
 - enable DebugNonSafepoints when directives sets printasm

Changes: https://git.openjdk.java.net/jdk/pull/3316/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3316&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264359
  Stats: 8 lines in 2 files changed: 5 ins; 3 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3316.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3316/head:pull/3316

PR: https://git.openjdk.java.net/jdk/pull/3316
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested

Vladimir Kozlov-2
On Thu, 1 Apr 2021 20:57:04 GMT, Nils Eliasson <[hidden email]> wrote:

> DebugNonSafepoints should be set when PrintAssembly is requested. This only happened for compile commands but not for compiler directives. This PR moves the check to compiler directives - that code path is used for both directives and commands. I am leaving the check and update in arguments.cpp - there might be some need for using flag PrintAssembly for stubs or wrappers, in a code path that doesn't use commands or directives.

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3316
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested

Tobias Hartmann-3
In reply to this post by Nils Eliasson-2
On Thu, 1 Apr 2021 20:57:04 GMT, Nils Eliasson <[hidden email]> wrote:

> DebugNonSafepoints should be set when PrintAssembly is requested. This only happened for compile commands but not for compiler directives. This PR moves the check to compiler directives - that code path is used for both directives and commands. I am leaving the check and update in arguments.cpp - there might be some need for using flag PrintAssembly for stubs or wrappers, in a code path that doesn't use commands or directives.

Looks good.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3316
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested

Nils Eliasson-2
On Tue, 6 Apr 2021 05:55:08 GMT, Tobias Hartmann <[hidden email]> wrote:

>> DebugNonSafepoints should be set when PrintAssembly is requested. This only happened for compile commands but not for compiler directives. This PR moves the check to compiler directives - that code path is used for both directives and commands. I am leaving the check and update in arguments.cpp - there might be some need for using flag PrintAssembly for stubs or wrappers, in a code path that doesn't use commands or directives.
>
> Looks good.

Thanks for the reviews Vladimir and Tobias!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3316
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested

Nils Eliasson-2
In reply to this post by Nils Eliasson-2
On Thu, 1 Apr 2021 20:57:04 GMT, Nils Eliasson <[hidden email]> wrote:

> DebugNonSafepoints should be set when PrintAssembly is requested. This only happened for compile commands but not for compiler directives. This PR moves the check to compiler directives - that code path is used for both directives and commands. I am leaving the check and update in arguments.cpp - there might be some need for using flag PrintAssembly for stubs or wrappers, in a code path that doesn't use commands or directives.

This pull request has now been integrated.

Changeset: 81325483
Author:    Nils Eliasson <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/81325483
Stats:     8 lines in 2 files changed: 5 ins; 3 del; 0 mod

8264359: Compiler directives should enable DebugNonSafepoints when PrintAssembly is requested

Reviewed-by: kvn, thartmann

-------------

PR: https://git.openjdk.java.net/jdk/pull/3316