RFR: 8264429: Test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264429: Test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build

Yi Yang
The test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build since it checks for `out.shouldContain("OpenJDK")`. Relax this restriction now.

Thanks~
Yang

-------------

Commit messages:
 - not assume OpenJDK build

Changes: https://git.openjdk.java.net/jdk/pull/3268/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3268&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264429
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3268.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3268/head:pull/3268

PR: https://git.openjdk.java.net/jdk/pull/3268
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264429: Test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build

Aleksey Shipilev-5
On Tue, 30 Mar 2021 14:08:19 GMT, Yi Yang <[hidden email]> wrote:

> The test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build since it checks for `out.shouldContain("OpenJDK")`. Relax this restriction now.
>
> Thanks~
> Yang

Looks fine. Please try to revert the original fix and see if the test still fails?

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3268
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264429: Test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build

Daniel D.Daugherty
In reply to this post by Yi Yang
On Tue, 30 Mar 2021 14:08:19 GMT, Yi Yang <[hidden email]> wrote:

> The test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build since it checks for `out.shouldContain("OpenJDK")`. Relax this restriction now.
>
> Thanks~
> Yang

Thumbs up.

This is a trivial fix and does not need to wait for 24 hours.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3268
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264429: Test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build

Yi Yang
On Tue, 30 Mar 2021 14:19:23 GMT, Daniel D. Daugherty <[hidden email]> wrote:

>> The test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build since it checks for `out.shouldContain("OpenJDK")`. Relax this restriction now.
>>
>> Thanks~
>> Yang
>
> Thumbs up.
>
> This is a trivial fix and does not need to wait for 24 hours.

Thanks @dcubed-ojdk @shipilev for the reviews, since it's a trivial fix, I think it can be integrated right now.

For @shipilev : Yes, it fails as expected when the original fix was reverted(See detailed [VerifyWithDefaultArchive.jtr.log](https://github.com/openjdk/jdk/files/6229798/VerifyWithDefaultArchive.jtr.log) attachment in this PR).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3268
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264429: Test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build

Yi Yang
In reply to this post by Yi Yang
On Tue, 30 Mar 2021 14:08:19 GMT, Yi Yang <[hidden email]> wrote:

> The test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build since it checks for `out.shouldContain("OpenJDK")`. Relax this restriction now.
>
> Thanks~
> Yang

This pull request has now been integrated.

Changeset: b6521988
Author:    Yi Yang <[hidden email]>
Committer: Daniel D. Daugherty <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/b6521988
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8264429: Test runtime/cds/appcds/VerifyWithDefaultArchive.java assumes OpenJDK build

Reviewed-by: dcubed, shade

-------------

PR: https://git.openjdk.java.net/jdk/pull/3268