RFR: 8264489: Add more logging to LargeCopyWithMark.java

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264489: Add more logging to LargeCopyWithMark.java

Stefan Karlsson-3
Add more logging to the LargeCopyWithMark.java test, to gather more information when this test fails with OOME.

The intention is to gather more info for JDK-8239089.

I consider this patch trivial, and expect to push it after I've gotten on Review.

-------------

Commit messages:
 - 8264489: Add more logging to LargeCopyWithMark.java

Changes: https://git.openjdk.java.net/jdk/pull/3282/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3282&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264489
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3282.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3282/head:pull/3282

PR: https://git.openjdk.java.net/jdk/pull/3282
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java

Kim Barrett-2
On Wed, 31 Mar 2021 06:56:23 GMT, Stefan Karlsson <[hidden email]> wrote:

> Add more logging to the LargeCopyWithMark.java test, to gather more information when this test fails with OOME.
>
> The intention is to gather more info for JDK-8239089.
>
> I consider this patch trivial, and expect to push it after I've gotten one Review.

Looks good, and trivial.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3282
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java

Stefan Karlsson-3
On Wed, 31 Mar 2021 08:39:02 GMT, Kim Barrett <[hidden email]> wrote:

>> Add more logging to the LargeCopyWithMark.java test, to gather more information when this test fails with OOME.
>>
>> The intention is to gather more info for JDK-8239089.
>>
>> I consider this patch trivial, and expect to push it after I've gotten one Review.
>
> Looks good, and trivial.

Thanks Kim!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3282
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java

Alan Bateman-2
In reply to this post by Stefan Karlsson-3
On Wed, 31 Mar 2021 06:56:23 GMT, Stefan Karlsson <[hidden email]> wrote:

> Add more logging to the LargeCopyWithMark.java test, to gather more information when this test fails with OOME.
>
> The intention is to gather more info for JDK-8239089.
>
> I consider this patch trivial, and expect to push it after I've gotten one Review.

test/jdk/java/io/BufferedInputStream/LargeCopyWithMark.java line 29:

> 27:  * @summary BufferedInputStream calculates negative array size with large
> 28:  *          streams and mark
> 29:  * @run main/othervm -Xmx4G -Xlog:gc,gc+heap,gc+ergo+heap -XX:+CrashOnOutOfMemoryError -XX:+IgnoreUnrecognizedVMOptions -XX:+G1ExitOnExpansionFailure LargeCopyWithMark

Looks okay but I assume you can split this line to avoid having a 170+ line in this file, this helps with future side-by-side review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3282
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java [v2]

Stefan Karlsson-3
In reply to this post by Stefan Karlsson-3
> Add more logging to the LargeCopyWithMark.java test, to gather more information when this test fails with OOME.
>
> The intention is to gather more info for JDK-8239089.
>
> I consider this patch trivial, and expect to push it after I've gotten one Review.

Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:

  Review Alan

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3282/files
  - new: https://git.openjdk.java.net/jdk/pull/3282/files/a7260c86..1828df10

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3282&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3282&range=00-01

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3282.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3282/head:pull/3282

PR: https://git.openjdk.java.net/jdk/pull/3282
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java [v2]

Stefan Karlsson-3
In reply to this post by Alan Bateman-2
On Wed, 31 Mar 2021 09:29:43 GMT, Alan Bateman <[hidden email]> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Review Alan
>
> test/jdk/java/io/BufferedInputStream/LargeCopyWithMark.java line 29:
>
>> 27:  * @summary BufferedInputStream calculates negative array size with large
>> 28:  *          streams and mark
>> 29:  * @run main/othervm -Xmx4G -Xlog:gc,gc+heap,gc+ergo+heap -XX:+CrashOnOutOfMemoryError -XX:+IgnoreUnrecognizedVMOptions -XX:+G1ExitOnExpansionFailure LargeCopyWithMark
>
> Looks okay but I assume you can split this line to avoid having a 170+ line in this file, this helps with future side-by-side review.

Thanks. I've added line breaks to make it easier to read.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3282
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java [v2]

Alan Bateman-2
In reply to this post by Stefan Karlsson-3
On Wed, 31 Mar 2021 11:15:43 GMT, Stefan Karlsson <[hidden email]> wrote:

>> Add more logging to the LargeCopyWithMark.java test, to gather more information when this test fails with OOME.
>>
>> The intention is to gather more info for JDK-8239089.
>>
>> I consider this patch trivial, and expect to push it after I've gotten one Review.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>
>   Review Alan

Marked as reviewed by alanb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3282
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java [v2]

Brian Burkhalter-3
In reply to this post by Stefan Karlsson-3
On Wed, 31 Mar 2021 11:15:43 GMT, Stefan Karlsson <[hidden email]> wrote:

>> Add more logging to the LargeCopyWithMark.java test, to gather more information when this test fails with OOME.
>>
>> The intention is to gather more info for JDK-8239089.
>>
>> I consider this patch trivial, and expect to push it after I've gotten one Review.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>
>   Review Alan

Marked as reviewed by bpb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3282
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java [v2]

Stefan Karlsson-3
On Wed, 31 Mar 2021 15:42:14 GMT, Brian Burkhalter <[hidden email]> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Review Alan
>
> Marked as reviewed by bpb (Reviewer).

Thanks for reviewing!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3282
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264489: Add more logging to LargeCopyWithMark.java

Stefan Karlsson-3
In reply to this post by Stefan Karlsson-3
On Wed, 31 Mar 2021 06:56:23 GMT, Stefan Karlsson <[hidden email]> wrote:

> Add more logging to the LargeCopyWithMark.java test, to gather more information when this test fails with OOME.
>
> The intention is to gather more info for JDK-8239089.
>
> I consider this patch trivial, and expect to push it after I've gotten one Review.

This pull request has now been integrated.

Changeset: 0fa35728
Author:    Stefan Karlsson <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/0fa35728
Stats:     3 lines in 1 file changed: 2 ins; 0 del; 1 mod

8264489: Add more logging to LargeCopyWithMark.java

Reviewed-by: kbarrett, alanb, bpb

-------------

PR: https://git.openjdk.java.net/jdk/pull/3282