RFR: 8264513: Cleanup CardTableBarrierSetC2::post_barrier

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264513: Cleanup CardTableBarrierSetC2::post_barrier

Aleksey Shipilev-5
There are few stale comments after CMS removal. We can also clean up some coding, while we are at it.

-------------

Commit messages:
 - 8264513: Cleanup CardTableBarrierSetC2::post_barrier

Changes: https://git.openjdk.java.net/jdk/pull/3285/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3285&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264513
  Stats: 20 lines in 1 file changed: 5 ins; 5 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3285.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3285/head:pull/3285

PR: https://git.openjdk.java.net/jdk/pull/3285
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264513: Cleanup CardTableBarrierSetC2::post_barrier

Aleksey Shipilev-5
On Wed, 31 Mar 2021 13:46:47 GMT, Aleksey Shipilev <[hidden email]> wrote:

> There are few stale comments after CMS removal. We can also clean up some coding, while we are at it.

Gentle ping?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3285
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264513: Cleanup CardTableBarrierSetC2::post_barrier

Thomas Schatzl-4
In reply to this post by Aleksey Shipilev-5
On Wed, 31 Mar 2021 13:46:47 GMT, Aleksey Shipilev <[hidden email]> wrote:

> There are few stale comments after CMS removal. We can also clean up some coding, while we are at it.

Lgtm.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3285
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264513: Cleanup CardTableBarrierSetC2::post_barrier

Aleksey Shipilev-5
On Thu, 8 Apr 2021 07:18:01 GMT, Thomas Schatzl <[hidden email]> wrote:

>> There are few stale comments after CMS removal. We can also clean up some coding, while we are at it.
>
> Lgtm.

Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3285
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264513: Cleanup CardTableBarrierSetC2::post_barrier

Aleksey Shipilev-5
In reply to this post by Aleksey Shipilev-5
On Wed, 31 Mar 2021 13:46:47 GMT, Aleksey Shipilev <[hidden email]> wrote:

> There are few stale comments after CMS removal. We can also clean up some coding, while we are at it.

This pull request has now been integrated.

Changeset: 1c6b1134
Author:    Aleksey Shipilev <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/1c6b1134
Stats:     20 lines in 1 file changed: 5 ins; 5 del; 10 mod

8264513: Cleanup CardTableBarrierSetC2::post_barrier

Reviewed-by: tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/3285