RFR: 8264546: Dependencies: Context class is always an InstanceKlass

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264546: Dependencies: Context class is always an InstanceKlass

Vladimir Ivanov-2
A trivial refactoring/cleanup: dependency context is always an InstanceKlass, but `Dependencies` uses `Klass*`.
Migrate` Dependencies` from `Klass*` to `InstanceKlass*`.

Testing: hs-tier1 - hs-tier2

-------------

Commit messages:
 - Convert context_type from Klass* to InstanceKlass*

Changes: https://git.openjdk.java.net/jdk/pull/3293/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3293&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264546
  Stats: 33 lines in 4 files changed: 1 ins; 6 del; 26 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3293.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3293/head:pull/3293

PR: https://git.openjdk.java.net/jdk/pull/3293
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264546: Dependencies: Context class is always an InstanceKlass

Vladimir Kozlov-2
On Wed, 31 Mar 2021 21:27:14 GMT, Vladimir Ivanov <[hidden email]> wrote:

> A trivial refactoring/cleanup: dependency context is always an InstanceKlass, but `Dependencies` uses `Klass*`.
> Migrate` Dependencies` from `Klass*` to `InstanceKlass*`.
>
> Testing: hs-tier1 - hs-tier2

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3293
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264546: Dependencies: Context class is always an InstanceKlass

Vladimir Ivanov-2
On Wed, 31 Mar 2021 22:02:54 GMT, Vladimir Kozlov <[hidden email]> wrote:

>> A trivial refactoring/cleanup: dependency context is always an InstanceKlass, but `Dependencies` uses `Klass*`.
>> Migrate` Dependencies` from `Klass*` to `InstanceKlass*`.
>>
>> Testing: hs-tier1 - hs-tier2
>
> Good.

Thanks, Vladimir.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3293
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264546: Dependencies: Context class is always an InstanceKlass

Vladimir Ivanov-2
In reply to this post by Vladimir Ivanov-2
On Wed, 31 Mar 2021 21:27:14 GMT, Vladimir Ivanov <[hidden email]> wrote:

> A trivial refactoring/cleanup: dependency context is always an InstanceKlass, but `Dependencies` uses `Klass*`.
> Migrate` Dependencies` from `Klass*` to `InstanceKlass*`.
>
> Testing: hs-tier1 - hs-tier2

This pull request has now been integrated.

Changeset: 80681b54
Author:    Vladimir Ivanov <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/80681b54
Stats:     33 lines in 4 files changed: 1 ins; 6 del; 26 mod

8264546: Dependencies: Context class is always an InstanceKlass

Reviewed-by: kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/3293