RFR: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups

Vladimir Ivanov-2
Simplify `ClassHierarchyWalker::is_witness()`.

Testing: hs-tier1 - hs-tier4.

-------------

Commit messages:
 - Refactor ClassHierarchyWalker::is_witness()
 - Convert context_type from Klass* to InstanceKlass*

Changes: https://git.openjdk.java.net/jdk/pull/3297/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3297&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264548
  Stats: 68 lines in 4 files changed: 17 ins; 12 del; 39 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3297.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3297/head:pull/3297

PR: https://git.openjdk.java.net/jdk/pull/3297
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups

Vladimir Kozlov-2
On Wed, 31 Mar 2021 21:47:53 GMT, Vladimir Ivanov <[hidden email]> wrote:

> Simplify `ClassHierarchyWalker::is_witness()`.
>
> Testing: hs-tier1 - hs-tier4.

Looks like it has changes from: https://git.openjdk.java.net/jdk/pull/3293

-------------

Changes requested by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3297
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups

Vladimir Ivanov-2
On Wed, 31 Mar 2021 22:05:20 GMT, Vladimir Kozlov <[hidden email]> wrote:

>> Simplify `ClassHierarchyWalker::is_witness()`.
>>
>> Testing: hs-tier1 - hs-tier4.
>
> Looks like it has changes from: https://git.openjdk.java.net/jdk/pull/3293

I created it as a dependent PR.

I think that's the way it works (https://github.com/openjdk/skara/pull/1087 which was used as an example in [1] looks similar).

[1] https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html

-------------

PR: https://git.openjdk.java.net/jdk/pull/3297
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups [v2]

Vladimir Ivanov-2
In reply to this post by Vladimir Ivanov-2
> Simplify `ClassHierarchyWalker::is_witness()`.
>
> Testing: hs-tier1 - hs-tier4.

Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  Refactor ClassHierarchyWalker::is_witness()

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3297/files
  - new: https://git.openjdk.java.net/jdk/pull/3297/files/fc92da2e..b7f31326

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3297&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3297&range=00-01

  Stats: 3498 lines in 125 files changed: 2719 ins; 306 del; 473 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3297.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3297/head:pull/3297

PR: https://git.openjdk.java.net/jdk/pull/3297
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups [v2]

Vladimir Ivanov-2
In reply to this post by Vladimir Ivanov-2
On Thu, 1 Apr 2021 09:08:01 GMT, Vladimir Ivanov <[hidden email]> wrote:

>> Looks like it has changes from: https://git.openjdk.java.net/jdk/pull/3293
>
> I created it as a dependent PR.
>
> I think that's the way it works (https://github.com/openjdk/skara/pull/1087 which was used as an example in [1] looks similar).
>
> [1] https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html

Anyway, I rebased and force-pushed the patch since #3293 is integrated now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3297
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups [v2]

Vladimir Kozlov-2
In reply to this post by Vladimir Ivanov-2
On Thu, 1 Apr 2021 14:03:48 GMT, Vladimir Ivanov <[hidden email]> wrote:

>> Simplify `ClassHierarchyWalker::is_witness()`.
>>
>> Testing: hs-tier1 - hs-tier4.
>
> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
>
>   Refactor ClassHierarchyWalker::is_witness()

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3297
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups [v2]

Vladimir Kozlov-2
On Thu, 1 Apr 2021 16:32:31 GMT, Vladimir Kozlov <[hidden email]> wrote:

>> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
>>
>>   Refactor ClassHierarchyWalker::is_witness()
>
> Good.

> I created it as a dependent PR.
>
> I think that's the way it works ([openjdk/skara#1087](https://github.com/openjdk/skara/pull/1087) which was used as an example in [1] looks similar).
>
> [1] https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html

As I understand when you are creating PR which based on an other PR you have to change `base:` from `master` to corresponding `pr/3293`  so that only difference of current PR are seen.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3297
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups [v2]

Vladimir Ivanov-2
On Thu, 1 Apr 2021 17:23:57 GMT, Vladimir Kozlov <[hidden email]> wrote:

>> Good.
>
>> I created it as a dependent PR.
>>
>> I think that's the way it works ([openjdk/skara#1087](https://github.com/openjdk/skara/pull/1087) which was used as an example in [1] looks similar).
>>
>> [1] https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005232.html
>
> As I understand when you are creating PR which based on an other PR you have to change `base:` from `master` to corresponding `pr/3293`  so that only difference of current PR are seen.

Thanks, Vladimir.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3297
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups

Vladimir Ivanov-2
In reply to this post by Vladimir Ivanov-2
On Wed, 31 Mar 2021 21:47:53 GMT, Vladimir Ivanov <[hidden email]> wrote:

> Simplify `ClassHierarchyWalker::is_witness()`.
>
> Testing: hs-tier1 - hs-tier4.

This pull request has now been integrated.

Changeset: f60e81bf
Author:    Vladimir Ivanov <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/f60e81bf
Stats:     35 lines in 1 file changed: 16 ins; 6 del; 13 mod

8264548: Dependencies: ClassHierarchyWalker::is_witness() cleanups

Reviewed-by: kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/3297