RFR: 8264554: X509KeyManagerImpl calls getProtectionParameter with incorrect alias

[Xue-Lei Andrew Fan]

In X509KeyManagerImpl.java, a composited  entry alias consists three parts: an UID counter, a builder index and the real entry alias (See the makeAlias() method).  While calling the KeyStore.Builder.getProtectionParameter(String alias) method, the real entry alias should be used instead, rather than the composited entry alias.

Simple and straightforward update, no new regression test.

-------------

Commit messages:
 - 8264554: X509KeyManagerImpl calls getProtectionParameter with incorrect alias

Changes: https://git.openjdk.java.net/jdk/pull/3326/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3326&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264554
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3326.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3326/head:pull/3326

PR: https://git.openjdk.java.net/jdk/pull/3326

[Xue-Lei Andrew Fan]

On Fri, 2 Apr 2021 16:38:14 GMT, Xue-Lei Andrew Fan <[hidden email]> wrote:

> In X509KeyManagerImpl.java, a composited  entry alias consists three parts: an UID counter, a builder index and the real entry alias (See the makeAlias() method).  While calling the KeyStore.Builder.getProtectionParameter(String alias) method, the real entry alias should be used instead, rather than the composited entry alias.
>
> Simple and straightforward update, no new regression test.

ping ...

-------------

PR: https://git.openjdk.java.net/jdk/pull/3326

[Sean Mullan-2]

On Fri, 2 Apr 2021 16:38:14 GMT, Xue-Lei Andrew Fan <[hidden email]> wrote:

> In X509KeyManagerImpl.java, a composited  entry alias consists three parts: an UID counter, a builder index and the real entry alias (See the makeAlias() method).  While calling the KeyStore.Builder.getProtectionParameter(String alias) method, the real entry alias should be used instead, rather than the composited entry alias.
>
> Simple and straightforward update, no new regression test.

Marked as reviewed by mullan (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3326

[Xue-Lei Andrew Fan]

On Fri, 2 Apr 2021 16:38:14 GMT, Xue-Lei Andrew Fan <[hidden email]> wrote:

> In X509KeyManagerImpl.java, a composited  entry alias consists three parts: an UID counter, a builder index and the real entry alias (See the makeAlias() method).  While calling the KeyStore.Builder.getProtectionParameter(String alias) method, the real entry alias should be used instead, rather than the composited entry alias.
>
> Simple and straightforward update, no new regression test.

This pull request has now been integrated.

Changeset: 2f516996
Author:    Xue-Lei Andrew Fan <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/2f516996
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8264554: X509KeyManagerImpl calls getProtectionParameter with incorrect alias

Reviewed-by: mullan

-------------

PR: https://git.openjdk.java.net/jdk/pull/3326