RFR: 8264606: More comment for ECDH public key validation

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264606: More comment for ECDH public key validation

Xue-Lei Andrew Fan
Improve the readability by adding more comments in the ECDH public key validation implementation in JDK.

-------------

Commit messages:
 - 8264606: More comment for ECDH public key validation

Changes: https://git.openjdk.java.net/jdk/pull/3313/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3313&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264606
  Stats: 25 lines in 1 file changed: 18 ins; 1 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3313.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3313/head:pull/3313

PR: https://git.openjdk.java.net/jdk/pull/3313
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264606: More comment for ECDH public key validation [v2]

Xue-Lei Andrew Fan
> Improve the readability by adding more comments in the ECDH public key validation implementation in JDK.

Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:

  typo correct of unmapable character in the comment line

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3313/files
  - new: https://git.openjdk.java.net/jdk/pull/3313/files/04d7e1cc..11c2bcdf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3313&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3313&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3313.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3313/head:pull/3313

PR: https://git.openjdk.java.net/jdk/pull/3313
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264606: More comment for ECDH public key validation [v2]

Bradford Wetmore-2
On Fri, 2 Apr 2021 04:14:44 GMT, Xue-Lei Andrew Fan <[hidden email]> wrote:

>> Improve the readability by adding more comments in the ECDH public key validation implementation in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>
>   typo correct of unmapable character in the comment line

Marked as reviewed by wetmore (Reviewer).

src/jdk.crypto.ec/share/classes/sun/security/ec/ECDHKeyAgreement.java line 164:

> 162:     }
> 163:
> 164:     // Check whether a public key is valid, following the ECC

Coding conventions used to be /* */ for method description and multiline comments.

Otherwise, this work is much appreciated for any maintainers.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3313
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264606: More comment for ECDH public key validation

Xue-Lei Andrew Fan
In reply to this post by Xue-Lei Andrew Fan
On Thu, 1 Apr 2021 17:53:47 GMT, Xue-Lei Andrew Fan <[hidden email]> wrote:

> Improve the readability by adding more comments in the ECDH public key validation implementation in JDK.

This pull request has now been integrated.

Changeset: 177bc84f
Author:    Xue-Lei Andrew Fan <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/177bc84f
Stats:     25 lines in 1 file changed: 18 ins; 1 del; 6 mod

8264606: More comment for ECDH public key validation

Reviewed-by: wetmore

-------------

PR: https://git.openjdk.java.net/jdk/pull/3313