RFR: 8264610: Number.{byteValue, shortValue} spec should use @implSpec

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264610: Number.{byteValue, shortValue} spec should use @implSpec

Joe Darcy-2
Please review this small code change and its accompanying CSR:

 https://bugs.openjdk.java.net/browse/JDK-8264610

-------------

Commit messages:
 - Update second method.
 - 8264609: Number.shortValue spec should use @implSpec

Changes: https://git.openjdk.java.net/jdk/pull/3314/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3314&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264610
  Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3314.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3314/head:pull/3314

PR: https://git.openjdk.java.net/jdk/pull/3314
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264610: Number.{byteValue, shortValue} spec should use @implSpec

Paul Sandoz-2
On Thu, 1 Apr 2021 18:12:43 GMT, Joe Darcy <[hidden email]> wrote:

> Please review this small code change and its accompanying CSR:
>
>  https://bugs.openjdk.java.net/browse/JDK-8264610

Marked as reviewed by psandoz (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3314
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264610: Number.{byteValue, shortValue} spec should use @implSpec

Brian Burkhalter-3
In reply to this post by Joe Darcy-2
On Thu, 1 Apr 2021 18:12:43 GMT, Joe Darcy <[hidden email]> wrote:

> Please review this small code change and its accompanying CSR:
>
>  https://bugs.openjdk.java.net/browse/JDK-8264610

CSR also reviewed.

-------------

Marked as reviewed by bpb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3314
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264609 : Number.{byteValue, shortValue} spec should use @implSpec

Joe Darcy-2
In reply to this post by Joe Darcy-2
On Thu, 1 Apr 2021 18:12:43 GMT, Joe Darcy <[hidden email]> wrote:

> Please review this small code change and its accompanying CSR:
>
>  https://bugs.openjdk.java.net/browse/JDK-8264610

This pull request has now been integrated.

Changeset: b953386d
Author:    Joe Darcy <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/b953386d
Stats:     5 lines in 1 file changed: 2 ins; 0 del; 3 mod

8264609: Number.{byteValue, shortValue} spec should use @implSpec

Reviewed-by: psandoz, bpb

-------------

PR: https://git.openjdk.java.net/jdk/pull/3314