RFR: 8264626: C1 should be able to inline excluded methods

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264626: C1 should be able to inline excluded methods

Nils Eliasson-2
I noticed a behavioral between c1 and c2. In c2 excluded methods can still be inlined, which is the desired behaviour. Inlining is controlled separately. I propose a small change to c1 inlining that make it work in the same way.

-------------

Commit messages:
 - c1: allow inlining of excluded methods

Changes: https://git.openjdk.java.net/jdk/pull/3315/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3315&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264626
  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3315.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3315/head:pull/3315

PR: https://git.openjdk.java.net/jdk/pull/3315
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264626: C1 should be able to inline excluded methods

Igor Veresov-3
On Thu, 1 Apr 2021 20:32:53 GMT, Nils Eliasson <[hidden email]> wrote:

> I noticed a behavioral between c1 and c2. In c2 excluded methods can still be inlined, which is the desired behaviour. Inlining is controlled separately. I propose a small change to c1 inlining that make it work in the same way.

Looks good.

-------------

Marked as reviewed by iveresov (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3315
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264626: C1 should be able to inline excluded methods

Tobias Hartmann-3
In reply to this post by Nils Eliasson-2
On Thu, 1 Apr 2021 20:32:53 GMT, Nils Eliasson <[hidden email]> wrote:

> I noticed a behavioral between c1 and c2. In c2 excluded methods can still be inlined, which is the desired behaviour. Inlining is controlled separately. I propose a small change to c1 inlining that make it work in the same way.

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3315
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264626: C1 should be able to inline excluded methods

Nils Eliasson-2
On Tue, 6 Apr 2021 05:56:34 GMT, Tobias Hartmann <[hidden email]> wrote:

>> I noticed a behavioral between c1 and c2. In c2 excluded methods can still be inlined, which is the desired behaviour. Inlining is controlled separately. I propose a small change to c1 inlining that make it work in the same way.
>
> Looks good to me.

Thanks for the reviews Igor and Tobias!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3315
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264626: C1 should be able to inline excluded methods

Nils Eliasson-2
In reply to this post by Nils Eliasson-2
On Thu, 1 Apr 2021 20:32:53 GMT, Nils Eliasson <[hidden email]> wrote:

> I noticed a behavioral between c1 and c2. In c2 excluded methods can still be inlined, which is the desired behaviour. Inlining is controlled separately. I propose a small change to c1 inlining that make it work in the same way.

This pull request has now been integrated.

Changeset: ec7b0028
Author:    Nils Eliasson <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/ec7b0028
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

8264626: C1 should be able to inline excluded methods

Reviewed-by: iveresov, thartmann

-------------

PR: https://git.openjdk.java.net/jdk/pull/3315