RFR: 8264727: Remove extraneous whitespace from phase timings report

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264727: Remove extraneous whitespace from phase timings report

earthling-amzn
This extra space doesn't look like it was intended to improve any alignment of text in the report.

-------------

Commit messages:
 - Remove extraneous whitespace from phase timings report

Changes: https://git.openjdk.java.net/jdk/pull/3342/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3342&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264727
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3342.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3342/head:pull/3342

PR: https://git.openjdk.java.net/jdk/pull/3342
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264727: Remove extraneous whitespace from phase timings report

Aleksey Shipilev-5
On Mon, 5 Apr 2021 16:45:43 GMT, earthling-amzn <[hidden email]> wrote:

> This extra space doesn't look like it was intended to improve any alignment of text in the report.

Marked as reviewed by shade (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3342
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264727: Remove extraneous whitespace from phase timings report

Aleksey Shipilev-5
On Mon, 5 Apr 2021 16:49:47 GMT, Aleksey Shipilev <[hidden email]> wrote:

>> This extra space doesn't look like it was intended to improve any alignment of text in the report.
>
> Marked as reviewed by shade (Reviewer).

Created: https://bugs.openjdk.java.net/browse/JDK-8264727 -- rename this PR to "8264727: Shenandoah: Remove extraneous whitespace from phase timings report" to get it hooked up.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3342
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264727: Remove extraneous whitespace from phase timings report

Aleksey Shipilev-5
In reply to this post by earthling-amzn
On Mon, 5 Apr 2021 16:45:43 GMT, earthling-amzn <[hidden email]> wrote:

> This extra space doesn't look like it was intended to improve any alignment of text in the report.

Looks fine and trivial.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3342
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264727: Remove extraneous whitespace from phase timings report

Aleksey Shipilev-5
On Mon, 5 Apr 2021 17:02:55 GMT, Aleksey Shipilev <[hidden email]> wrote:

>> This extra space doesn't look like it was intended to improve any alignment of text in the report.
>
> Looks fine and trivial.

You need to resolve the integration blocker before integration: the PR title and bug synopsis are mismatched. You need "Shenandoah: " in the title.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3342
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264727: Remove extraneous whitespace from phase timings report

Aleksey Shipilev-5
In reply to this post by earthling-amzn
On Mon, 5 Apr 2021 16:45:43 GMT, earthling-amzn <[hidden email]> wrote:

> This extra space doesn't look like it was intended to improve any alignment of text in the report.

@earthling-amzn Still want to integrate this? You need to title this PR correctly for bots to catch it up.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3342
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264727: Shenandoah: Remove extraneous whitespace from phase timings report

earthling-amzn
In reply to this post by earthling-amzn
On Mon, 5 Apr 2021 16:45:43 GMT, earthling-amzn <[hidden email]> wrote:

> This extra space doesn't look like it was intended to improve any alignment of text in the report.

This pull request has now been integrated.

Changeset: ec31b3a1
Author:    William Kemper <[hidden email]>
Committer: Aleksey Shipilev <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/ec31b3a1
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8264727: Shenandoah: Remove extraneous whitespace from phase timings report

Reviewed-by: shade

-------------

PR: https://git.openjdk.java.net/jdk/pull/3342