RFR: 8264729: Orphan file - shouldn't be in sources.

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264729: Orphan file - shouldn't be in sources.

Jim Laskey-3
open/src/java.base/share/native/random/create_ziggurat_tables.c should not be in the sources.

-------------

Commit messages:
 - 8264729: Orphan file - shouldn't be in sources.

Changes: https://git.openjdk.java.net/jdk/pull/3343/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3343&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264729
  Stats: 688 lines in 1 file changed: 0 ins; 688 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3343.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3343/head:pull/3343

PR: https://git.openjdk.java.net/jdk/pull/3343
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264729: Orphan file - shouldn't be in sources.

Erik Joelsson-2
On Mon, 5 Apr 2021 17:06:24 GMT, Jim Laskey <[hidden email]> wrote:

> open/src/java.base/share/native/random/create_ziggurat_tables.c should not be in the sources.

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3343
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264729: Orphan file - shouldn't be in sources.

Brian Burkhalter-3
In reply to this post by Jim Laskey-3
On Mon, 5 Apr 2021 17:06:24 GMT, Jim Laskey <[hidden email]> wrote:

> open/src/java.base/share/native/random/create_ziggurat_tables.c should not be in the sources.

Marked as reviewed by bpb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3343
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264729: Orphan file - shouldn't be in sources. [v2]

Jim Laskey-3
In reply to this post by Jim Laskey-3
> open/src/java.base/share/native/random/create_ziggurat_tables.c should not be in the sources.

Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:

  Tests with bad copyright dates.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3343/files
  - new: https://git.openjdk.java.net/jdk/pull/3343/files/c003d155..3ae2db7d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3343&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3343&range=00-01

  Stats: 26 lines in 4 files changed: 23 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3343.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3343/head:pull/3343

PR: https://git.openjdk.java.net/jdk/pull/3343
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264729: Orphan file - shouldn't be in sources. [v3]

Jim Laskey-3
In reply to this post by Jim Laskey-3
> open/src/java.base/share/native/random/create_ziggurat_tables.c should not be in the sources.

Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:

  One more file missing copyright date

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3343/files
  - new: https://git.openjdk.java.net/jdk/pull/3343/files/3ae2db7d..90219a77

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3343&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3343&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3343.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3343/head:pull/3343

PR: https://git.openjdk.java.net/jdk/pull/3343
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264729: Random check-in failing header checks. [v3]

Erik Joelsson-2
On Mon, 5 Apr 2021 17:44:37 GMT, Jim Laskey <[hidden email]> wrote:

>> open/src/java.base/share/native/random/create_ziggurat_tables.c should not be in the sources.
>
> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>
>   One more file missing copyright date

test/jdk/java/util/Random/RandomTestBsi1999.java line 2:

> 1: /*
> 2:  * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.

Shouldn't this be:
2012, 2021,

-------------

PR: https://git.openjdk.java.net/jdk/pull/3343
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264729: Random check-in failing header checks. [v3]

Jim Laskey-3
On Mon, 5 Apr 2021 18:41:32 GMT, Erik Joelsson <[hidden email]> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   One more file missing copyright date
>
> test/jdk/java/util/Random/RandomTestBsi1999.java line 2:
>
>> 1: /*
>> 2:  * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>
> Shouldn't this be:
> 2012, 2021,

The earlier dates were while under development. As far as I know, this is the first time they appear. But I can change if that is the consensus.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3343
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264729: Random check-in failing header checks. [v4]

Jim Laskey-3
In reply to this post by Jim Laskey-3
> open/src/java.base/share/native/random/create_ziggurat_tables.c should not be in the sources.

Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:

  Include initial date.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3343/files
  - new: https://git.openjdk.java.net/jdk/pull/3343/files/90219a77..4aacf704

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3343&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3343&range=02-03

  Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3343.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3343/head:pull/3343

PR: https://git.openjdk.java.net/jdk/pull/3343
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264729: Random check-in failing header checks.

Jim Laskey-3
In reply to this post by Jim Laskey-3
On Mon, 5 Apr 2021 17:06:24 GMT, Jim Laskey <[hidden email]> wrote:

> open/src/java.base/share/native/random/create_ziggurat_tables.c should not be in the sources.

This pull request has now been integrated.

Changeset: 92018991
Author:    Jim Laskey <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/92018991
Stats:     715 lines in 6 files changed: 23 ins; 688 del; 4 mod

8264729: Random check-in failing header checks.

Reviewed-by: erikj, bpb

-------------

PR: https://git.openjdk.java.net/jdk/pull/3343