RFR: 8264759: x86_32 Minimal VM build failure after JDK-8262355

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264759: x86_32 Minimal VM build failure after JDK-8262355

Aleksey Shipilev-5
* For target hotspot_variant-minimal_libjvm_objs_sharedRuntime_x86_32.o:

-------------

Commit messages:
 - 8264759: x86_32 Minimal VM build failure after JDK-8262355

Changes: https://git.openjdk.java.net/jdk/pull/3353/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3353&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264759
  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3353.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3353/head:pull/3353

PR: https://git.openjdk.java.net/jdk/pull/3353
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264759: x86_32 Minimal VM build failure after JDK-8262355

Tobias Hartmann-3
On Tue, 6 Apr 2021 09:29:33 GMT, Aleksey Shipilev <[hidden email]> wrote:

> * For target hotspot_variant-minimal_libjvm_objs_sharedRuntime_x86_32.o:

Looks good and trivial to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3353
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264759: x86_32 Minimal VM build failure after JDK-8262355

Vladimir Kozlov-2
In reply to this post by Aleksey Shipilev-5
On Tue, 6 Apr 2021 09:29:33 GMT, Aleksey Shipilev <[hidden email]> wrote:

> * For target hotspot_variant-minimal_libjvm_objs_sharedRuntime_x86_32.o:

Trivial.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3353
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264759: x86_32 Minimal VM build failure after JDK-8262355 [v2]

Aleksey Shipilev-5
In reply to this post by Aleksey Shipilev-5
> * For target hotspot_variant-minimal_libjvm_objs_sharedRuntime_x86_32.o:

Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

  Avoid sweeping vzeroupper into save_vectors block

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3353/files
  - new: https://git.openjdk.java.net/jdk/pull/3353/files/86a5d8fd..4cf15f25

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3353&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3353&range=00-01

  Stats: 3 lines in 1 file changed: 2 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3353.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3353/head:pull/3353

PR: https://git.openjdk.java.net/jdk/pull/3353
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264759: x86_32 Minimal VM build failure after JDK-8262355 [v2]

Aleksey Shipilev-5
In reply to this post by Vladimir Kozlov-2
On Tue, 6 Apr 2021 17:59:11 GMT, Vladimir Kozlov <[hidden email]> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Avoid sweeping vzeroupper into save_vectors block
>
> Trivial.

Thanks! I realized that moving `vzeroupper` into `COMPILER2` block was not quite right, as we "handle" only the `save_vectors` branch with that `#ifdef`. Reverted that part in new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3353
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264759: x86_32 Minimal VM build failure after JDK-8262355 [v2]

Vladimir Kozlov-2
In reply to this post by Aleksey Shipilev-5
On Tue, 6 Apr 2021 18:09:58 GMT, Aleksey Shipilev <[hidden email]> wrote:

>> * For target hotspot_variant-minimal_libjvm_objs_sharedRuntime_x86_32.o:
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
>   Avoid sweeping vzeroupper into save_vectors block

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3353
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264759: x86_32 Minimal VM build failure after JDK-8262355

Aleksey Shipilev-5
In reply to this post by Aleksey Shipilev-5
On Tue, 6 Apr 2021 09:29:33 GMT, Aleksey Shipilev <[hidden email]> wrote:

> * For target hotspot_variant-minimal_libjvm_objs_sharedRuntime_x86_32.o:

This pull request has now been integrated.

Changeset: a756d8d7
Author:    Aleksey Shipilev <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/a756d8d7
Stats:     5 lines in 1 file changed: 5 ins; 0 del; 0 mod

8264759: x86_32 Minimal VM build failure after JDK-8262355

Reviewed-by: thartmann, kvn

-------------

PR: https://git.openjdk.java.net/jdk/pull/3353