RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"

Jim Laskey-3
SecureRandom is stochastic and will become unpredictable over time (hence the intermittent nature.

-------------

Commit messages:
 - 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"

Changes: https://git.openjdk.java.net/jdk/pull/3359/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3359&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264791
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3359.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3359/head:pull/3359

PR: https://git.openjdk.java.net/jdk/pull/3359
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v2]

Jim Laskey-3
> SecureRandom is stochastic and will become unpredictable over time (hence the intermittent nature.

Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:

  Add bug number

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3359/files
  - new: https://git.openjdk.java.net/jdk/pull/3359/files/94d04892..5f39180e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3359&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3359&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3359.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3359/head:pull/3359

PR: https://git.openjdk.java.net/jdk/pull/3359
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v2]

Joe Darcy-2
On Tue, 6 Apr 2021 16:46:06 GMT, Jim Laskey <[hidden email]> wrote:

>> SecureRandom is stochastic and will become unpredictable over time (hence the intermittent nature).
>
> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>
>   Add bug number

Marked as reviewed by darcy (Reviewer).

test/jdk/java/util/Random/RandomTestBsi1999.java line 442:

> 440:             setRNG(factory.name());
> 441:
> 442:             if (factory.name().equals("Random")) {

A string-switch on the currentRNG name might be better structured here.

test/jdk/java/util/Random/RandomTestBsi1999.java line 443:

> 441:
> 442:             if (currentRNG.equals("SecureRandom")) {
> 443:                 // Bug: 8264791

It is generally not necessary to include bug ids in the text of changesets.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3359
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v2]

Brian Burkhalter-3
In reply to this post by Jim Laskey-3
On Tue, 6 Apr 2021 16:46:06 GMT, Jim Laskey <[hidden email]> wrote:

>> SecureRandom is stochastic and will become unpredictable over time (hence the intermittent nature).
>
> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>
>   Add bug number

Marked as reviewed by bpb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3359
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v2]

Daniel D.Daugherty
In reply to this post by Jim Laskey-3
On Tue, 6 Apr 2021 16:46:06 GMT, Jim Laskey <[hidden email]> wrote:

>> SecureRandom is stochastic and will become unpredictable over time (hence the intermittent nature).
>
> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>
>   Add bug number

Marked as reviewed by dcubed (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3359
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v2]

Daniel D.Daugherty
In reply to this post by Joe Darcy-2
On Tue, 6 Apr 2021 16:45:15 GMT, Joe Darcy <[hidden email]> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>>
>>   Add bug number
>
> test/jdk/java/util/Random/RandomTestBsi1999.java line 443:
>
>> 441:
>> 442:             if (currentRNG.equals("SecureRandom")) {
>> 443:                 // Bug: 8264791
>
> It is generally not necessary to include bug ids in the text of changesets.

Should you add an "@bug 8264791" in the header instead?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3359
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive" [v3]

Jim Laskey-3
In reply to this post by Jim Laskey-3
> SecureRandom is stochastic and will become unpredictable over time (hence the intermittent nature).

Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:

  Remove bug number

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3359/files
  - new: https://git.openjdk.java.net/jdk/pull/3359/files/5f39180e..6e3f3055

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3359&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3359&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3359.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3359/head:pull/3359

PR: https://git.openjdk.java.net/jdk/pull/3359
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"

Jim Laskey-3
In reply to this post by Jim Laskey-3
On Tue, 6 Apr 2021 16:33:55 GMT, Jim Laskey <[hidden email]> wrote:

> SecureRandom is stochastic and will become unpredictable over time (hence the intermittent nature).

This pull request has now been integrated.

Changeset: 0f13e227
Author:    Jim Laskey <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/0f13e227
Stats:     3 lines in 1 file changed: 2 ins; 0 del; 1 mod

8264791: java/util/Random/RandomTestBsi1999.java failed "java.security.SecureRandom nextFloat consecutive"

Reviewed-by: darcy, bpb, dcubed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3359