RFR: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr

Jie Fu-2
Hi all,

test-lib fails to build due to three javac warnings:

-------------

Commit messages:
 - 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr

Changes: https://git.openjdk.java.net/jdk/pull/3367/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3367&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264809
  Stats: 5 lines in 3 files changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3367.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3367/head:pull/3367

PR: https://git.openjdk.java.net/jdk/pull/3367
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr

Roger Riggs-2
On Wed, 7 Apr 2021 03:34:15 GMT, Jie Fu <[hidden email]> wrote:

> Hi all,
>
> test-lib fails to build due to three javac warnings:

Looks good.
It seems only the build-test-lib make rule has error on warnings set.
When running the tests, the compiles do not fail. (though the warnings are produced).

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3367
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr

Jie Fu-2
On Wed, 7 Apr 2021 13:48:57 GMT, Roger Riggs <[hidden email]> wrote:

>> Hi all,
>>
>> test-lib fails to build due to three javac warnings:
>
> Looks good.
> It seems only the build-test-lib make rule has error on warnings set.
> When running the tests, the compiles do not fail. (though the warnings are produced).

Thanks @RogerRiggs .

-------------

PR: https://git.openjdk.java.net/jdk/pull/3367
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr

Jie Fu-2
In reply to this post by Jie Fu-2
On Wed, 7 Apr 2021 03:34:15 GMT, Jie Fu <[hidden email]> wrote:

> Hi all,
>
> test-lib fails to build due to three javac warnings:

This pull request has now been integrated.

Changeset: 88eb2919
Author:    Jie Fu <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/88eb2919
Stats:     5 lines in 3 files changed: 1 ins; 0 del; 4 mod

8264809: test-lib fails to build due to some warnings in ASN1Formatter and jfr

Reviewed-by: rriggs

-------------

PR: https://git.openjdk.java.net/jdk/pull/3367