RFR: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp

Vladimir Ivanov-2
Miscellaneous cleanups in dependencies.cpp.

Testing:
* [x] hs-tier1 - hs-tier4

-------------

Commit messages:
 - KlassDepChange::involves_context
 - KlassDepChange::_new_type
 - Dependencies::is_concrete_method
 - Dependencies::verify_method_context
 - int -> uint

Changes: https://git.openjdk.java.net/jdk/pull/3385/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3385&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264871
  Stats: 156 lines in 2 files changed: 70 ins; 58 del; 28 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3385.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3385/head:pull/3385

PR: https://git.openjdk.java.net/jdk/pull/3385
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp

Nils Eliasson-2
On Wed, 7 Apr 2021 21:51:30 GMT, Vladimir Ivanov <[hidden email]> wrote:

> Miscellaneous cleanups in dependencies.cpp.
>
> Testing:
> * [x] hs-tier1 - hs-tier4

Looks good.

-------------

Marked as reviewed by neliasso (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3385
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp

Vladimir Ivanov-2
On Fri, 9 Apr 2021 11:10:33 GMT, Nils Eliasson <[hidden email]> wrote:

>> Miscellaneous cleanups in dependencies.cpp.
>>
>> Testing:
>> * [x] hs-tier1 - hs-tier4
>
> Looks good.

Thanks for the review, Nils.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3385
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp

Vladimir Ivanov-2
In reply to this post by Vladimir Ivanov-2
On Wed, 7 Apr 2021 21:51:30 GMT, Vladimir Ivanov <[hidden email]> wrote:

> Miscellaneous cleanups in dependencies.cpp.
>
> Testing:
> * [x] hs-tier1 - hs-tier4

This pull request has now been integrated.

Changeset: 07c8ff47
Author:    Vladimir Ivanov <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/07c8ff47
Stats:     156 lines in 2 files changed: 70 ins; 58 del; 28 mod

8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp

Reviewed-by: neliasso

-------------

PR: https://git.openjdk.java.net/jdk/pull/3385