RFR: 8264872: Dependencies: Migrate to PerfData counters

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264872: Dependencies: Migrate to PerfData counters

Vladimir Ivanov-2
Migrate performance counters on `Dependencies` (`deps_find_witness_*`) to `PerfData`.

Testing:
- [x] hs-tier1 - hs-tier2

-------------

Depends on: https://git.openjdk.java.net/jdk/pull/3385

Commit messages:
 - CountingClassHierarchyIterator
 - Migrate to PerfData
 - Depenencies perf counters

Changes: https://git.openjdk.java.net/jdk/pull/3386/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3386&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264872
  Stats: 121 lines in 4 files changed: 61 ins; 37 del; 23 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3386.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3386/head:pull/3386

PR: https://git.openjdk.java.net/jdk/pull/3386
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264872: Dependencies: Migrate to PerfData counters

Vladimir Kozlov-2
On Wed, 7 Apr 2021 22:07:18 GMT, Vladimir Ivanov <[hidden email]> wrote:

> Migrate performance counters on `Dependencies` (`deps_find_witness_*`) to `PerfData`.
>
> Testing:
> - [x] hs-tier1 - hs-tier2

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3386
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264872: Dependencies: Migrate to PerfData counters

Nils Eliasson-2
In reply to this post by Vladimir Ivanov-2
On Wed, 7 Apr 2021 22:07:18 GMT, Vladimir Ivanov <[hidden email]> wrote:

> Migrate performance counters on `Dependencies` (`deps_find_witness_*`) to `PerfData`.
>
> Testing:
> - [x] hs-tier1 - hs-tier2

Looks good.

src/hotspot/share/code/dependencies.cpp line 1212:

> 1210: };
> 1211:
> 1212: PerfCounter* ClassHierarchyWalker::_perf_find_witness_anywhere_calls_count   = NULL;

Align '=' on all three or skip extra space

-------------

Marked as reviewed by neliasso (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3386
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264872: Dependencies: Migrate to PerfData counters

Nils Eliasson-2
On Fri, 9 Apr 2021 11:15:54 GMT, Nils Eliasson <[hidden email]> wrote:

>> Migrate performance counters on `Dependencies` (`deps_find_witness_*`) to `PerfData`.
>>
>> Testing:
>> - [x] hs-tier1 - hs-tier2
>
> src/hotspot/share/code/dependencies.cpp line 1212:
>
>> 1210: };
>> 1211:
>> 1212: PerfCounter* ClassHierarchyWalker::_perf_find_witness_anywhere_calls_count   = NULL;
>
> Align '=' on all three or skip extra space

I'm refering to the whitespace before '= NULL'

-------------

PR: https://git.openjdk.java.net/jdk/pull/3386
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264872: Dependencies: Migrate to PerfData counters [v2]

Vladimir Ivanov-2
In reply to this post by Vladimir Ivanov-2
> Migrate performance counters on `Dependencies` (`deps_find_witness_*`) to `PerfData`.
>
> Testing:
> - [x] hs-tier1 - hs-tier2

Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:

 - Merge branch 'master' into 8264872.perf_counters
 - Formatting
 - CountingClassHierarchyIterator
 - Migrate to PerfData
 - Depenencies perf counters
 - KlassDepChange::involves_context
 - KlassDepChange::_new_type
 - Dependencies::is_concrete_method
 - Dependencies::verify_method_context
 - int -> uint

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3386/files
  - new: https://git.openjdk.java.net/jdk/pull/3386/files/3567e0f0..a810a10e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3386&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3386&range=00-01

  Stats: 5774 lines in 162 files changed: 4269 ins; 1012 del; 493 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3386.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3386/head:pull/3386

PR: https://git.openjdk.java.net/jdk/pull/3386
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264872: Dependencies: Migrate to PerfData counters [v2]

Vladimir Ivanov-2
In reply to this post by Nils Eliasson-2
On Fri, 9 Apr 2021 11:42:19 GMT, Nils Eliasson <[hidden email]> wrote:

>> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>>
>>  - Merge branch 'master' into 8264872.perf_counters
>>  - Formatting
>>  - CountingClassHierarchyIterator
>>  - Migrate to PerfData
>>  - Depenencies perf counters
>>  - KlassDepChange::involves_context
>>  - KlassDepChange::_new_type
>>  - Dependencies::is_concrete_method
>>  - Dependencies::verify_method_context
>>  - int -> uint
>
> Looks good.

Thanks for the reviews, Vladimir and Nils.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3386
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264872: Dependencies: Migrate to PerfData counters

Vladimir Ivanov-2
In reply to this post by Vladimir Ivanov-2
On Wed, 7 Apr 2021 22:07:18 GMT, Vladimir Ivanov <[hidden email]> wrote:

> Migrate performance counters on `Dependencies` (`deps_find_witness_*`) to `PerfData`.
>
> Testing:
> - [x] hs-tier1 - hs-tier2

This pull request has now been integrated.

Changeset: 76bd313d
Author:    Vladimir Ivanov <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/76bd313d
Stats:     121 lines in 4 files changed: 61 ins; 37 del; 23 mod

8264872: Dependencies: Migrate to PerfData counters

Reviewed-by: kvn, neliasso

-------------

PR: https://git.openjdk.java.net/jdk/pull/3386