RFR: 8264873: Dependencies: Split ClassHierarchyWalker

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264873: Dependencies: Split ClassHierarchyWalker

Vladimir Ivanov-2
Split ClassHierarchyWalker into ConcreteMethodFinder and ConcreteSubtypeFinder.

Testing:
- [x] hs-tier1 - hs-tier4

-------------

Depends on: https://git.openjdk.java.net/jdk/pull/3386

Commit messages:
 - Split ClassHierarchyWalker into ConcreteMethodFinder and ConcreteSubtypeFinder

Changes: https://git.openjdk.java.net/jdk/pull/3387/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3387&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264873
  Stats: 438 lines in 1 file changed: 134 ins; 144 del; 160 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3387.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3387/head:pull/3387

PR: https://git.openjdk.java.net/jdk/pull/3387
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264873: Dependencies: Split ClassHierarchyWalker [v2]

Vladimir Ivanov-2
> Split ClassHierarchyWalker into ConcreteMethodFinder and ConcreteSubtypeFinder.
>
> Testing:
> - [x] hs-tier1 - hs-tier4

Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:

  Fix formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3387/files
  - new: https://git.openjdk.java.net/jdk/pull/3387/files/6b905d78..071de4cd

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3387&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3387&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3387.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3387/head:pull/3387

PR: https://git.openjdk.java.net/jdk/pull/3387
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264873: Dependencies: Split ClassHierarchyWalker [v2]

Vladimir Kozlov-2
On Wed, 7 Apr 2021 22:38:58 GMT, Vladimir Ivanov <[hidden email]> wrote:

>> Split ClassHierarchyWalker into ConcreteMethodFinder and ConcreteSubtypeFinder.
>>
>> Testing:
>> - [x] hs-tier1 - hs-tier4
>
> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>
>   Fix formatting

Marked as reviewed by kvn (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3387
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264873: Dependencies: Split ClassHierarchyWalker [v3]

Vladimir Ivanov-2
In reply to this post by Vladimir Ivanov-2
> Split ClassHierarchyWalker into ConcreteMethodFinder and ConcreteSubtypeFinder.
>
> Testing:
> - [x] hs-tier1 - hs-tier4

Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:

 - Merge branch 'master' into 8264873.cha.split
 - Fix formatting
 - Split ClassHierarchyWalker into ConcreteMethodFinder and ConcreteSubtypeFinder
 - CountingClassHierarchyIterator
 - Migrate to PerfData
 - Depenencies perf counters
 - KlassDepChange::involves_context
 - KlassDepChange::_new_type
 - Dependencies::is_concrete_method
 - Dependencies::verify_method_context
 - ... and 1 more: https://git.openjdk.java.net/jdk/compare/76bd313d...e38b995c

-------------

Changes: https://git.openjdk.java.net/jdk/pull/3387/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3387&range=02
  Stats: 437 lines in 1 file changed: 134 ins; 144 del; 159 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3387.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3387/head:pull/3387

PR: https://git.openjdk.java.net/jdk/pull/3387
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264873: Dependencies: Split ClassHierarchyWalker [v3]

Tobias Hartmann-3
On Fri, 9 Apr 2021 22:41:42 GMT, Vladimir Ivanov <[hidden email]> wrote:

>> Split ClassHierarchyWalker into ConcreteMethodFinder and ConcreteSubtypeFinder.
>>
>> Testing:
>> - [x] hs-tier1 - hs-tier4
>
> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>
>  - Merge branch 'master' into 8264873.cha.split
>  - Fix formatting
>  - Split ClassHierarchyWalker into ConcreteMethodFinder and ConcreteSubtypeFinder
>  - CountingClassHierarchyIterator
>  - Migrate to PerfData
>  - Depenencies perf counters
>  - KlassDepChange::involves_context
>  - KlassDepChange::_new_type
>  - Dependencies::is_concrete_method
>  - Dependencies::verify_method_context
>  - ... and 1 more: https://git.openjdk.java.net/jdk/compare/76bd313d...e38b995c

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3387