RFR: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo

Aleksey Shipilev-5
Noticed this when backporting JDK-8242557: there is a trivial copy-paste error in exception message. See:
 https://hg.openjdk.java.net/jdk/jdk/rev/645c71334acd#l1.58

-------------

Commit messages:
 - 8264923: PNGImageWriter.write_zTXt throws Exception with a typo

Changes: https://git.openjdk.java.net/jdk/pull/3397/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3397&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264923
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3397.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3397/head:pull/3397

PR: https://git.openjdk.java.net/jdk/pull/3397
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo

Alexey Ivanov-2
On Thu, 8 Apr 2021 13:00:49 GMT, Aleksey Shipilev <[hidden email]> wrote:

> Noticed this when backporting JDK-8242557: there is a trivial copy-paste error in exception message. See:
>  https://hg.openjdk.java.net/jdk/jdk/rev/645c71334acd#l1.58

Marked as reviewed by aivanov (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3397
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo

Jayathirth D V-2
In reply to this post by Aleksey Shipilev-5
On Thu, 8 Apr 2021 13:00:49 GMT, Aleksey Shipilev <[hidden email]> wrote:

> Noticed this when backporting JDK-8242557: there is a trivial copy-paste error in exception message. See:
>  https://hg.openjdk.java.net/jdk/jdk/rev/645c71334acd#l1.58

Marked as reviewed by jdv (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3397
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo

Alexander Zvegintsev-2
In reply to this post by Aleksey Shipilev-5
On Thu, 8 Apr 2021 13:00:49 GMT, Aleksey Shipilev <[hidden email]> wrote:

> Noticed this when backporting JDK-8242557: there is a trivial copy-paste error in exception message. See:
>  https://hg.openjdk.java.net/jdk/jdk/rev/645c71334acd#l1.58

Marked as reviewed by azvegint (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3397
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo

Alexander Zuev-3
In reply to this post by Aleksey Shipilev-5
On Thu, 8 Apr 2021 13:00:49 GMT, Aleksey Shipilev <[hidden email]> wrote:

> Noticed this when backporting JDK-8242557: there is a trivial copy-paste error in exception message. See:
>  https://hg.openjdk.java.net/jdk/jdk/rev/645c71334acd#l1.58

Marked as reviewed by kizune (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3397
Reply | Threaded
Open this post in threaded view
|

Re: RFR: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo

Aleksey Shipilev-5
On Thu, 8 Apr 2021 16:55:49 GMT, Alexander Zuev <[hidden email]> wrote:

>> Noticed this when backporting JDK-8242557: there is a trivial copy-paste error in exception message. See:
>>  https://hg.openjdk.java.net/jdk/jdk/rev/645c71334acd#l1.58
>
> Marked as reviewed by kizune (Reviewer).

Whoa, so many reviews, thanks! :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/3397
Reply | Threaded
Open this post in threaded view
|

Integrated: 8264923: PNGImageWriter.write_zTXt throws Exception with a typo

Aleksey Shipilev-5
In reply to this post by Aleksey Shipilev-5
On Thu, 8 Apr 2021 13:00:49 GMT, Aleksey Shipilev <[hidden email]> wrote:

> Noticed this when backporting JDK-8242557: there is a trivial copy-paste error in exception message. See:
>  https://hg.openjdk.java.net/jdk/jdk/rev/645c71334acd#l1.58

This pull request has now been integrated.

Changeset: 051c117b
Author:    Aleksey Shipilev <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/051c117b
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8264923: PNGImageWriter.write_zTXt throws Exception with a typo

Reviewed-by: aivanov, jdv, azvegint, kizune

-------------

PR: https://git.openjdk.java.net/jdk/pull/3397