Quantcast

RFR JDK-8175288: [TESTBUG] sun/tools/jcmd/TestJcmdDefaults.java failed to parse output of other java process

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR JDK-8175288: [TESTBUG] sun/tools/jcmd/TestJcmdDefaults.java failed to parse output of other java process

harold seigel
Hi,

Please review this JDK-10 fix for test
sun/tools/jcmd/TestJcmdDefaults.java.  The test gets a list of Java
processes and tries to match them to a regular expression. But the match
fails if the name of one of the Java processes contains a line terminator.

The fix adds "(?s)" to the regular expression used by the test. The
"(?s)" enables dotall mode, meaning the "." in the test's regular
expression accepts any characters including line terminators.

Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8175288/webrev/

JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8175288

The change was regression tested on Linux, macOS X, Solaris, and Windows
using RDB.  The modified regular expression was tested using a small
Java program that was fed command lines similar to the one that caused
the test to fail.

Thanks, Harold

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR JDK-8175288: [TESTBUG] sun/tools/jcmd/TestJcmdDefaults.java failed to parse output of other java process

George Triantafillou
Hi Harold,

Looks good!

-George

On 3/16/2017 4:06 PM, harold seigel wrote:

> Hi,
>
> Please review this JDK-10 fix for test
> sun/tools/jcmd/TestJcmdDefaults.java.  The test gets a list of Java
> processes and tries to match them to a regular expression. But the
> match fails if the name of one of the Java processes contains a line
> terminator.
>
> The fix adds "(?s)" to the regular expression used by the test. The
> "(?s)" enables dotall mode, meaning the "." in the test's regular
> expression accepts any characters including line terminators.
>
> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8175288/webrev/
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8175288
>
> The change was regression tested on Linux, macOS X, Solaris, and
> Windows using RDB.  The modified regular expression was tested using a
> small Java program that was fed command lines similar to the one that
> caused the test to fail.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR JDK-8175288: [TESTBUG] sun/tools/jcmd/TestJcmdDefaults.java failed to parse output of other java process

harold seigel
Thanks George!

Harold


On 3/16/2017 4:16 PM, George Triantafillou wrote:

> Hi Harold,
>
> Looks good!
>
> -George
>
> On 3/16/2017 4:06 PM, harold seigel wrote:
>> Hi,
>>
>> Please review this JDK-10 fix for test
>> sun/tools/jcmd/TestJcmdDefaults.java.  The test gets a list of Java
>> processes and tries to match them to a regular expression. But the
>> match fails if the name of one of the Java processes contains a line
>> terminator.
>>
>> The fix adds "(?s)" to the regular expression used by the test. The
>> "(?s)" enables dotall mode, meaning the "." in the test's regular
>> expression accepts any characters including line terminators.
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8175288/webrev/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8175288
>>
>> The change was regression tested on Linux, macOS X, Solaris, and
>> Windows using RDB.  The modified regular expression was tested using
>> a small Java program that was fed command lines similar to the one
>> that caused the test to fail.
>>
>> Thanks, Harold
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR JDK-8175288: [TESTBUG] sun/tools/jcmd/TestJcmdDefaults.java failed to parse output of other java process

Mikhailo Seledtsov
Change looks good.

Misha


On 03/16/2017 01:18 PM, harold seigel wrote:

> Thanks George!
>
> Harold
>
>
> On 3/16/2017 4:16 PM, George Triantafillou wrote:
>> Hi Harold,
>>
>> Looks good!
>>
>> -George
>>
>> On 3/16/2017 4:06 PM, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this JDK-10 fix for test
>>> sun/tools/jcmd/TestJcmdDefaults.java.  The test gets a list of Java
>>> processes and tries to match them to a regular expression. But the
>>> match fails if the name of one of the Java processes contains a line
>>> terminator.
>>>
>>> The fix adds "(?s)" to the regular expression used by the test. The
>>> "(?s)" enables dotall mode, meaning the "." in the test's regular
>>> expression accepts any characters including line terminators.
>>>
>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8175288/webrev/
>>>
>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8175288
>>>
>>> The change was regression tested on Linux, macOS X, Solaris, and
>>> Windows using RDB.  The modified regular expression was tested using
>>> a small Java program that was fed command lines similar to the one
>>> that caused the test to fail.
>>>
>>> Thanks, Harold
>>>
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR JDK-8175288: [TESTBUG] sun/tools/jcmd/TestJcmdDefaults.java failed to parse output of other java process

harold seigel
Hi Misha,

Thanks for the review!

Harold


On 3/16/2017 5:08 PM, mikhailo wrote:

> Change looks good.
>
> Misha
>
>
> On 03/16/2017 01:18 PM, harold seigel wrote:
>> Thanks George!
>>
>> Harold
>>
>>
>> On 3/16/2017 4:16 PM, George Triantafillou wrote:
>>> Hi Harold,
>>>
>>> Looks good!
>>>
>>> -George
>>>
>>> On 3/16/2017 4:06 PM, harold seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this JDK-10 fix for test
>>>> sun/tools/jcmd/TestJcmdDefaults.java.  The test gets a list of Java
>>>> processes and tries to match them to a regular expression. But the
>>>> match fails if the name of one of the Java processes contains a
>>>> line terminator.
>>>>
>>>> The fix adds "(?s)" to the regular expression used by the test. The
>>>> "(?s)" enables dotall mode, meaning the "." in the test's regular
>>>> expression accepts any characters including line terminators.
>>>>
>>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8175288/webrev/
>>>>
>>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8175288
>>>>
>>>> The change was regression tested on Linux, macOS X, Solaris, and
>>>> Windows using RDB.  The modified regular expression was tested
>>>> using a small Java program that was fed command lines similar to
>>>> the one that caused the test to fail.
>>>>
>>>> Thanks, Harold
>>>>
>>>
>>
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR JDK-8175288: [TESTBUG] sun/tools/jcmd/TestJcmdDefaults.java failed to parse output of other java process

Christian Tornqvist
In reply to this post by harold seigel
Hi Harold,

This looks good, thanks for fixing this.

Thanks,
Christian

> On Mar 16, 2017, at 4:06 PM, harold seigel <[hidden email]> wrote:
>
> Hi,
>
> Please review this JDK-10 fix for test sun/tools/jcmd/TestJcmdDefaults.java.  The test gets a list of Java processes and tries to match them to a regular expression. But the match fails if the name of one of the Java processes contains a line terminator.
>
> The fix adds "(?s)" to the regular expression used by the test. The "(?s)" enables dotall mode, meaning the "." in the test's regular expression accepts any characters including line terminators.
>
> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8175288/webrev/
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8175288
>
> The change was regression tested on Linux, macOS X, Solaris, and Windows using RDB.  The modified regular expression was tested using a small Java program that was fed command lines similar to the one that caused the test to fail.
>
> Thanks, Harold
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR JDK-8175288: [TESTBUG] sun/tools/jcmd/TestJcmdDefaults.java failed to parse output of other java process

harold seigel
Hi Christian,

Thanks for the review!

Harold


On 3/17/2017 8:25 AM, Christian Tornqvist wrote:

> Hi Harold,
>
> This looks good, thanks for fixing this.
>
> Thanks,
> Christian
>
>> On Mar 16, 2017, at 4:06 PM, harold seigel <[hidden email]> wrote:
>>
>> Hi,
>>
>> Please review this JDK-10 fix for test sun/tools/jcmd/TestJcmdDefaults.java.  The test gets a list of Java processes and tries to match them to a regular expression. But the match fails if the name of one of the Java processes contains a line terminator.
>>
>> The fix adds "(?s)" to the regular expression used by the test. The "(?s)" enables dotall mode, meaning the "." in the test's regular expression accepts any characters including line terminators.
>>
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8175288/webrev/
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8175288
>>
>> The change was regression tested on Linux, macOS X, Solaris, and Windows using RDB.  The modified regular expression was tested using a small Java program that was fed command lines similar to the one that caused the test to fail.
>>
>> Thanks, Harold
>>

Loading...