RFR: JDK-8179373: javac -verbose logs the class path multiple times

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8179373: javac -verbose logs the class path multiple times

Liam Miller-Cushon
Please review (another) trivial fix for the output from "javac -verbose".


Thanks,
Liam
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8179373: javac -verbose logs the class path multiple times

Martin Buchholz-3
Looks good.

Maybe add comment
+            verbosePath = false; // print once per compile
Maybe rename "l" to "line".

On Thu, Jan 11, 2018 at 10:12 PM, Liam Miller-Cushon <[hidden email]> wrote:
Please review (another) trivial fix for the output from "javac -verbose".


Thanks,
Liam

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8179373: javac -verbose logs the class path multiple times

Liam Miller-Cushon

On Fri, Jan 12, 2018 at 6:51 AM, Martin Buchholz <[hidden email]> wrote:
Looks good.

Maybe add comment
+            verbosePath = false; // print once per compile
Maybe rename "l" to "line".

On Thu, Jan 11, 2018 at 10:12 PM, Liam Miller-Cushon <[hidden email]> wrote:
Please review (another) trivial fix for the output from "javac -verbose".


Thanks,
Liam


Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8179373: javac -verbose logs the class path multiple times

Liam Miller-Cushon
The changeset is attached and ready to push.

On Fri, Jan 12, 2018 at 8:31 AM, Liam Miller-Cushon <[hidden email]> wrote:

On Fri, Jan 12, 2018 at 6:51 AM, Martin Buchholz <[hidden email]> wrote:
Looks good.

Maybe add comment
+            verbosePath = false; // print once per compile
Maybe rename "l" to "line".

On Thu, Jan 11, 2018 at 10:12 PM, Liam Miller-Cushon <[hidden email]> wrote:
Please review (another) trivial fix for the output from "javac -verbose".


Thanks,
Liam




8179373.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8179373: javac -verbose logs the class path multiple times

Martin Buchholz-3
Pushed by this semi-imposter javac engineer.

On Thu, Jan 25, 2018 at 3:19 PM, Liam Miller-Cushon <[hidden email]> wrote:
The changeset is attached and ready to push.

On Fri, Jan 12, 2018 at 8:31 AM, Liam Miller-Cushon <[hidden email]> wrote:

On Fri, Jan 12, 2018 at 6:51 AM, Martin Buchholz <[hidden email]> wrote:
Looks good.

Maybe add comment
+            verbosePath = false; // print once per compile
Maybe rename "l" to "line".

On Thu, Jan 11, 2018 at 10:12 PM, Liam Miller-Cushon <[hidden email]> wrote:
Please review (another) trivial fix for the output from "javac -verbose".


Thanks,
Liam