Quantcast

RFR: JDK-8180198: make bootcycle-images fail with uses of -d64 flags

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: JDK-8180198: make bootcycle-images fail with uses of -d64 flags

Erik Joelsson
With the removal of the -d64 flag, bootcycle builds started failing.
This patch stops trying to use -d64 completely for the boot jdk since it
shouldn't be needed for either JDK 8 or 9. The checks that used this
parameter to see if the JVM was 64 bit has been rewritten to instead
look at the version string.

This is for JDK 10.

Bug: https://bugs.openjdk.java.net/browse/JDK-8180198

Webrev: http://cr.openjdk.java.net/~erikj/8180198/webrev.01/

/Erik

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: JDK-8180198: make bootcycle-images fail with uses of -d64 flags

Mandy Chung

> On May 12, 2017, at 11:30 AM, Erik Joelsson <[hidden email]> wrote:
>
> With the removal of the -d64 flag, bootcycle builds started failing. This patch stops trying to use -d64 completely for the boot jdk since it shouldn't be needed for either JDK 8 or 9. The checks that used this parameter to see if the JVM was 64 bit has been rewritten to instead look at the version string.
>
> This is for JDK 10.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8180198
>
> Webrev: http://cr.openjdk.java.net/~erikj/8180198/webrev.01/


Looks fine to me.

Mandy
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: JDK-8180198: make bootcycle-images fail with uses of -d64 flags

Kumar Srinivasan
In reply to this post by Erik Joelsson

Looks good, and thanks for fixing this quickly!.

Kumar

> With the removal of the -d64 flag, bootcycle builds started failing.
> This patch stops trying to use -d64 completely for the boot jdk since
> it shouldn't be needed for either JDK 8 or 9. The checks that used
> this parameter to see if the JVM was 64 bit has been rewritten to
> instead look at the version string.
>
> This is for JDK 10.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8180198
>
> Webrev: http://cr.openjdk.java.net/~erikj/8180198/webrev.01/
>
> /Erik
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: JDK-8180198: make bootcycle-images fail with uses of -d64 flags

Tim Bell
Erik:

Looks good to me as well.

Tim

On 05/12/17 11:36, Kumar Srinivasan wrote:

>
> Looks good, and thanks for fixing this quickly!.
>
> Kumar
>
>> With the removal of the -d64 flag, bootcycle builds started failing.
>> This patch stops trying to use -d64 completely for the boot jdk since
>> it shouldn't be needed for either JDK 8 or 9. The checks that used
>> this parameter to see if the JVM was 64 bit has been rewritten to
>> instead look at the version string.
>>
>> This is for JDK 10.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180198
>>
>> Webrev: http://cr.openjdk.java.net/~erikj/8180198/webrev.01/
>>
>> /Erik
>>
>

Loading...