RFR: JDK-8186156: Fix a11y and HTML issues in java.net and javax.net packages

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RFR: JDK-8186156: Fix a11y and HTML issues in java.net and javax.net packages

Jonathan Gibbons
Please review the following fix for accessibility and HTML issues in the
java.net and javax.net packages.

The only edit of note is that a table was simply removed from the top of
URLConnection. The table was an "HTML art" depiction of actions on a
timeline, complete with an ASCII-art time arrow. My initial reaction was
to replace it with an ordered list ... but then I noticed the table was
already immediately followed by the explanatory list I would have
written. So the table was effectively redundant, and it seemd best to
remove it.

JBS: https://bugs.openjdk.java.net/browse/JDK-8186156
Webrev: http://cr.openjdk.java.net/~jjg/8186156/webrev.00
API: http://cr.openjdk.java.net/~jjg/8186156/api.00

-- Jon
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: JDK-8186156: Fix a11y and HTML issues in java.net and javax.net packages

Lance Andersen
+1

> On Aug 11, 2017, at 6:52 PM, Jonathan Gibbons <[hidden email]> wrote:
>
> Please review the following fix for accessibility and HTML issues in the java.net and javax.net packages.
>
> The only edit of note is that a table was simply removed from the top of URLConnection. The table was an "HTML art" depiction of actions on a timeline, complete with an ASCII-art time arrow. My initial reaction was to replace it with an ordered list ... but then I noticed the table was already immediately followed by the explanatory list I would have written. So the table was effectively redundant, and it seemd best to remove it.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8186156
> Webrev: http://cr.openjdk.java.net/~jjg/8186156/webrev.00
> API: http://cr.openjdk.java.net/~jjg/8186156/api.00
>
> -- Jon

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[hidden email] <mailto:[hidden email]>



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: RFR: JDK-8186156: Fix a11y and HTML issues in java.net and javax.net packages

Mandy Chung
In reply to this post by Jonathan Gibbons


On 8/11/17 3:52 PM, Jonathan Gibbons wrote:

> Please review the following fix for accessibility and HTML issues in
> the java.net and javax.net packages.
>
> The only edit of note is that a table was simply removed from the top
> of URLConnection. The table was an "HTML art" depiction of actions on
> a timeline, complete with an ASCII-art time arrow. My initial reaction
> was to replace it with an ordered list ... but then I noticed the
> table was already immediately followed by the explanatory list I would
> have written. So the table was effectively redundant, and it seemd
> best to remove it.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8186156
> Webrev: http://cr.openjdk.java.net/~jjg/8186156/webrev.00
> API: http://cr.openjdk.java.net/~jjg/8186156/api.00

The table in URLConnection does look redundant.  I think it's okay to
remove it.

src/java.base/share/classes/java/net/URLPermission.java

+ * <ul>
+ * <li>"POST,GET,DELETE"
+ * <li>"GET:X-Foo-Request,X-Bar-Request"
+ * <li>"POST,GET:Header1,Header2"
+ * </ul>

It may be good to add <p> in the next sentence "The first example..."

Otherwise looks fine.

Mandy

Loading...