RFR: JDK-8189061 - serviceability/sa/TestInstanceKlassSize.java - Unable to find instance klass for null

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8189061 - serviceability/sa/TestInstanceKlassSize.java - Unable to find instance klass for null

Sharath Ballal

Hello,

 

Pls review this simple fix for excluding sun.util.PreHashedMap from TestInstanceKlassSize.java.

sun.util.PreHashedMap can be lazily loaded due to JDK-8186517 and hence we have excluded it from the test.

 

Issue: https://bugs.openjdk.java.net/browse/JDK-8189061

Webrev: http://cr.openjdk.java.net/~sballal/8189061/webrev.00/

 

 

Thanks,

Sharath

 

 

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8189061 - serviceability/sa/TestInstanceKlassSize.java - Unable to find instance klass for null

Jini George
Your fix looks good to me, Sharath.

Thanks,
Jini (Not a Reviewer).

On 10/23/2017 10:49 AM, Sharath Ballal wrote:

> Hello,
>
> Pls review this simple fix for excluding sun.util.PreHashedMap from
> TestInstanceKlassSize.java.
>
> sun.util.PreHashedMap can be lazily loaded due to JDK-8186517
> <https://bugs.openjdk.java.net/browse/JDK-8186517> and hence we have
> excluded it from the test.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8189061
>
> Webrev: http://cr.openjdk.java.net/~sballal/8189061/webrev.00/
>
> Thanks,
>
> Sharath
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8189061 - serviceability/sa/TestInstanceKlassSize.java - Unable to find instance klass for null

David Holmes
In reply to this post by Sharath Ballal
Looks good!

Thanks,
David

On 23/10/2017 3:19 PM, Sharath Ballal wrote:

> Hello,
>
> Pls review this simple fix for excluding sun.util.PreHashedMap from
> TestInstanceKlassSize.java.
>
> sun.util.PreHashedMap can be lazily loaded due to JDK-8186517
> <https://bugs.openjdk.java.net/browse/JDK-8186517> and hence we have
> excluded it from the test.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8189061
>
> Webrev: http://cr.openjdk.java.net/~sballal/8189061/webrev.00/
>
> Thanks,
>
> Sharath
>
Reply | Threaded
Open this post in threaded view
|

RE: RFR: JDK-8189061 - serviceability/sa/TestInstanceKlassSize.java - Unable to find instance klass for null

Sharath Ballal
In reply to this post by Jini George
Thanks Jini.


Thanks,
Sharath


-----Original Message-----
From: Jini George
Sent: Monday, October 23, 2017 11:10 AM
To: Sharath Ballal; [hidden email]
Subject: Re: RFR: JDK-8189061 - serviceability/sa/TestInstanceKlassSize.java - Unable to find instance klass for null

Your fix looks good to me, Sharath.

Thanks,
Jini (Not a Reviewer).

On 10/23/2017 10:49 AM, Sharath Ballal wrote:

> Hello,
>
> Pls review this simple fix for excluding sun.util.PreHashedMap from
> TestInstanceKlassSize.java.
>
> sun.util.PreHashedMap can be lazily loaded due to JDK-8186517
> <https://bugs.openjdk.java.net/browse/JDK-8186517> and hence we have
> excluded it from the test.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8189061
>
> Webrev: http://cr.openjdk.java.net/~sballal/8189061/webrev.00/
>
> Thanks,
>
> Sharath
>
Reply | Threaded
Open this post in threaded view
|

RE: RFR: JDK-8189061 - serviceability/sa/TestInstanceKlassSize.java - Unable to find instance klass for null

Sharath Ballal
In reply to this post by David Holmes
Thanks David.


Thanks,
Sharath


-----Original Message-----
From: David Holmes
Sent: Monday, October 23, 2017 11:27 AM
To: Sharath Ballal; [hidden email]
Subject: Re: RFR: JDK-8189061 - serviceability/sa/TestInstanceKlassSize.java - Unable to find instance klass for null

Looks good!

Thanks,
David

On 23/10/2017 3:19 PM, Sharath Ballal wrote:

> Hello,
>
> Pls review this simple fix for excluding sun.util.PreHashedMap from
> TestInstanceKlassSize.java.
>
> sun.util.PreHashedMap can be lazily loaded due to JDK-8186517
> <https://bugs.openjdk.java.net/browse/JDK-8186517> and hence we have
> excluded it from the test.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8189061
>
> Webrev: http://cr.openjdk.java.net/~sballal/8189061/webrev.00/
>
> Thanks,
>
> Sharath
>