RFR: JDK-8189782: As com.sun.tools.javac.api.JavacTool misreports number of arguments consumed

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8189782: As com.sun.tools.javac.api.JavacTool misreports number of arguments consumed

Jan Lahoda
Hi,

JavaCompiler.isSupportedOption returns 1 for options like "-proc:none",
which does not seem right. The proposed patch resolves that.

Bug: https://bugs.openjdk.java.net/browse/JDK-8189782
Webrev: http://cr.openjdk.java.net/~jlahoda/8189782/webrev.00/

How does it look?

Thanks,
    Jan
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8189782: As com.sun.tools.javac.api.JavacTool misreports number of arguments consumed

Jonathan Gibbons
OK.

isSupportedOption is a sad method, but the patch is in line with its
current spec.

-- Jon

On 12/08/2017 09:18 AM, Jan Lahoda wrote:

> Hi,
>
> JavaCompiler.isSupportedOption returns 1 for options like
> "-proc:none", which does not seem right. The proposed patch resolves
> that.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189782
> Webrev: http://cr.openjdk.java.net/~jlahoda/8189782/webrev.00/
>
> How does it look?
>
> Thanks,
>    Jan