RFR: JDK-8191204 Post-consolidation cleaning up of the build system

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8191204 Post-consolidation cleaning up of the build system

Magnus Ihse Bursie
I think this is the last round of the post-consolidation cleaning up of
the build system. I'm removing some now-redundant checks, aligning to
more common calling practice, and speeding up the hg status check (which
was becoming more urgent as the repo grow in size).

Bug: https://bugs.openjdk.java.net/browse/JDK-8191204
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8191204-post-consolidation-cleanup/webrev.01

/Magnus
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8191204 Post-consolidation cleaning up of the build system

Tim Bell
Magnus:

> I think this is the last round of the post-consolidation cleaning up of
> the build system. I'm removing some now-redundant checks, aligning to
> more common calling practice, and speeding up the hg status check (which
> was becoming more urgent as the repo grow in size).
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191204
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8191204-post-consolidation-cleanup/webrev.01

Looks good.

For make/hotspot/lib/CompileLibjsig.gmk I see there will be a merge with
the fix for JDK-8190418, but that should be trivial.

Tim


Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8191204 Post-consolidation cleaning up of the build system

David Holmes
In reply to this post by Magnus Ihse Bursie
Hi Magnus,

All seems reasonable.

Thanks,
David

On 14/11/2017 9:17 PM, Magnus Ihse Bursie wrote:

> I think this is the last round of the post-consolidation cleaning up of
> the build system. I'm removing some now-redundant checks, aligning to
> more common calling practice, and speeding up the hg status check (which
> was becoming more urgent as the repo grow in size).
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191204
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8191204-post-consolidation-cleanup/webrev.01 
>
>
> /Magnus