RFR: JDK-8193352: SA: Test for the clhsdb 'thread' and 'threads' commands

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8193352: SA: Test for the clhsdb 'thread' and 'threads' commands

Jini George
Hello,

I would like to request reviews for:

Id: https://bugs.openjdk.java.net/browse/JDK-8193352
Webrev: http://cr.openjdk.java.net/~jgeorge/8193352/webrev.00/index.html

This is a test case for the clhsdb 'thread' and 'threads' commands. This
also includes a minor fix for the incorrect printing of the text
'Couldn't find thread -a' when the 'thread -a' command is specified.

Thanks,
Jini.
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193352: SA: Test for the clhsdb 'thread' and 'threads' commands

serguei.spitsyn@oracle.com
Hi Jini,

This looks good to me.

Thanks,
Serguei


On 1/5/18 00:41, Jini George wrote:

> Hello,
>
> I would like to request reviews for:
>
> Id: https://bugs.openjdk.java.net/browse/JDK-8193352
> Webrev: http://cr.openjdk.java.net/~jgeorge/8193352/webrev.00/index.html
>
> This is a test case for the clhsdb 'thread' and 'threads' commands.
> This also includes a minor fix for the incorrect printing of the text
> 'Couldn't find thread -a' when the 'thread -a' command is specified.
>
> Thanks,
> Jini.

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193352: SA: Test for the clhsdb 'thread' and 'threads' commands

Jini George
Thanks much, Serguei. Could I please get one more review for this ?

Thanks,
Jini.

On 1/6/2018 1:26 AM, [hidden email] wrote:

> Hi Jini,
>
> This looks good to me.
>
> Thanks,
> Serguei
>
>
> On 1/5/18 00:41, Jini George wrote:
>> Hello,
>>
>> I would like to request reviews for:
>>
>> Id: https://bugs.openjdk.java.net/browse/JDK-8193352
>> Webrev: http://cr.openjdk.java.net/~jgeorge/8193352/webrev.00/index.html
>>
>> This is a test case for the clhsdb 'thread' and 'threads' commands.
>> This also includes a minor fix for the incorrect printing of the text
>> 'Couldn't find thread -a' when the 'thread -a' command is specified.
>>
>> Thanks,
>> Jini.
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193352: SA: Test for the clhsdb 'thread' and 'threads' commands

Jini George
Have an updated webrev with the copyright year modified to 2018.

Thanks,
Jini.

On 1/8/2018 11:30 AM, Jini George wrote:

> Thanks much, Serguei. Could I please get one more review for this ?
>
> Thanks,
> Jini.
>
> On 1/6/2018 1:26 AM, [hidden email] wrote:
>> Hi Jini,
>>
>> This looks good to me.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 1/5/18 00:41, Jini George wrote:
>>> Hello,
>>>
>>> I would like to request reviews for:
>>>
>>> Id: https://bugs.openjdk.java.net/browse/JDK-8193352
>>> Webrev: http://cr.openjdk.java.net/~jgeorge/8193352/webrev.00/index.html
>>>
>>> This is a test case for the clhsdb 'thread' and 'threads' commands.
>>> This also includes a minor fix for the incorrect printing of the text
>>> 'Couldn't find thread -a' when the 'thread -a' command is specified.
>>>
>>> Thanks,
>>> Jini.
>>
Reply | Threaded
Open this post in threaded view
|

RE: RFR: JDK-8193352: SA: Test for the clhsdb 'thread' and 'threads' commands

Sharath Ballal
Looks Good Jini.


Thanks,
Sharath


-----Original Message-----
From: Jini George
Sent: Tuesday, January 09, 2018 2:03 PM
To: [hidden email]
Subject: Re: RFR: JDK-8193352: SA: Test for the clhsdb 'thread' and 'threads' commands

Have an updated webrev with the copyright year modified to 2018.

Thanks,
Jini.

On 1/8/2018 11:30 AM, Jini George wrote:

> Thanks much, Serguei. Could I please get one more review for this ?
>
> Thanks,
> Jini.
>
> On 1/6/2018 1:26 AM, [hidden email] wrote:
>> Hi Jini,
>>
>> This looks good to me.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 1/5/18 00:41, Jini George wrote:
>>> Hello,
>>>
>>> I would like to request reviews for:
>>>
>>> Id: https://bugs.openjdk.java.net/browse/JDK-8193352
>>> Webrev:
>>> http://cr.openjdk.java.net/~jgeorge/8193352/webrev.00/index.html
>>>
>>> This is a test case for the clhsdb 'thread' and 'threads' commands.
>>> This also includes a minor fix for the incorrect printing of the
>>> text 'Couldn't find thread -a' when the 'thread -a' command is specified.
>>>
>>> Thanks,
>>> Jini.
>>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193352: SA: Test for the clhsdb 'thread' and 'threads' commands

Jini George
Thanks much, Sharath.

- Jini.

On 1/10/2018 5:45 PM, Sharath Ballal wrote:

> Looks Good Jini.
>
>
> Thanks,
> Sharath
>
>
> -----Original Message-----
> From: Jini George
> Sent: Tuesday, January 09, 2018 2:03 PM
> To: [hidden email]
> Subject: Re: RFR: JDK-8193352: SA: Test for the clhsdb 'thread' and 'threads' commands
>
> Have an updated webrev with the copyright year modified to 2018.
>
> Thanks,
> Jini.
>
> On 1/8/2018 11:30 AM, Jini George wrote:
>> Thanks much, Serguei. Could I please get one more review for this ?
>>
>> Thanks,
>> Jini.
>>
>> On 1/6/2018 1:26 AM, [hidden email] wrote:
>>> Hi Jini,
>>>
>>> This looks good to me.
>>>
>>> Thanks,
>>> Serguei
>>>
>>>
>>> On 1/5/18 00:41, Jini George wrote:
>>>> Hello,
>>>>
>>>> I would like to request reviews for:
>>>>
>>>> Id: https://bugs.openjdk.java.net/browse/JDK-8193352
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~jgeorge/8193352/webrev.00/index.html
>>>>
>>>> This is a test case for the clhsdb 'thread' and 'threads' commands.
>>>> This also includes a minor fix for the incorrect printing of the
>>>> text 'Couldn't find thread -a' when the 'thread -a' command is specified.
>>>>
>>>> Thanks,
>>>> Jini.
>>>