RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build

Sharath Ballal

Hello,

 

Requesting reviews for:

 

JBS Id:     https://bugs.openjdk.java.net/browse/JDK-8193506

Webrev: http://cr.openjdk.java.net/~sballal/8193506/webrev.00/

 

I tested the changes in an open only workspace.  Also the test ran successfully in JPRT and Mach5.

 

 

 

Thanks,

Sharath

 

 

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build

David Holmes
Looks good.

Thanks,
David

On 28/12/2017 2:24 PM, Sharath Ballal wrote:

> Hello,
>
> Requesting reviews for:
>
> JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193506
>
> Webrev: http://cr.openjdk.java.net/~sballal/8193506/webrev.00/
>
> I tested the changes in an open only workspace.  Also the test ran
> successfully in JPRT and Mach5.
>
> Thanks,
>
> Sharath
>
Reply | Threaded
Open this post in threaded view
|

RE: RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build

Sharath Ballal
Thanks for the review David.
Could I have another review pls ?


Thanks,
Sharath


-----Original Message-----
From: David Holmes
Sent: Friday, December 29, 2017 6:08 AM
To: Sharath Ballal; [hidden email]
Subject: Re: RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build

Looks good.

Thanks,
David

On 28/12/2017 2:24 PM, Sharath Ballal wrote:

> Hello,
>
> Requesting reviews for:
>
> JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193506
>
> Webrev: http://cr.openjdk.java.net/~sballal/8193506/webrev.00/
>
> I tested the changes in an open only workspace.  Also the test ran
> successfully in JPRT and Mach5.
>
> Thanks,
>
> Sharath
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build

Chris Plummer
+1

Chris

On 1/1/18 1:32 AM, Sharath Ballal wrote:

> Thanks for the review David.
> Could I have another review pls ?
>
>
> Thanks,
> Sharath
>
>
> -----Original Message-----
> From: David Holmes
> Sent: Friday, December 29, 2017 6:08 AM
> To: Sharath Ballal; [hidden email]
> Subject: Re: RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build
>
> Looks good.
>
> Thanks,
> David
>
> On 28/12/2017 2:24 PM, Sharath Ballal wrote:
>> Hello,
>>
>> Requesting reviews for:
>>
>> JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193506
>>
>> Webrev: http://cr.openjdk.java.net/~sballal/8193506/webrev.00/
>>
>> I tested the changes in an open only workspace.� Also the test ran
>> successfully in JPRT and Mach5.
>>
>> Thanks,
>>
>> Sharath
>>


Reply | Threaded
Open this post in threaded view
|

RE: RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build

Sharath Ballal
Thank You Chris.


Thanks,
Sharath


-----Original Message-----
From: Chris Plummer
Sent: Tuesday, January 02, 2018 11:30 PM
To: Sharath Ballal; David Holmes; [hidden email]
Subject: Re: RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build

+1

Chris

On 1/1/18 1:32 AM, Sharath Ballal wrote:

> Thanks for the review David.
> Could I have another review pls ?
>
>
> Thanks,
> Sharath
>
>
> -----Original Message-----
> From: David Holmes
> Sent: Friday, December 29, 2017 6:08 AM
> To: Sharath Ballal; [hidden email]
> Subject: Re: RFR: JDK-8193506 - serviceability/sa/TestClassDump.java
> fails in OpenJDK build
>
> Looks good.
>
> Thanks,
> David
>
> On 28/12/2017 2:24 PM, Sharath Ballal wrote:
>> Hello,
>>
>> Requesting reviews for:
>>
>> JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193506
>>
>> Webrev: http://cr.openjdk.java.net/~sballal/8193506/webrev.00/
>>
>> I tested the changes in an open only workspace. Also the test ran
>> successfully in JPRT and Mach5.
>>
>> Thanks,
>>
>> Sharath
>>