RFR: JDK-8193512: remove remnants of javah from jdk/jdk10 repo

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8193512: remove remnants of javah from jdk/jdk10 repo

Jonathan Gibbons
Please review these changes to remove the remnants of javah (and in a
couple of tests, some remnants of apt and an earlier version of javap)
from the repo, now that the tool itself has been removed.

JBS: https://bugs.openjdk.java.net/browse/JDK-8193512
Webrev: http://cr.openjdk.java.net/~jjg/8193512/webrev.00/

-- Jon
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193512: remove remnants of javah from jdk/jdk10 repo

joe darcy
Looks fine.

-Joe

On 12/19/2017 1:52 PM, Jonathan Gibbons wrote:
> Please review these changes to remove the remnants of javah (and in a
> couple of tests, some remnants of apt and an earlier version of javap)
> from the repo, now that the tool itself has been removed.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8193512
> Webrev: http://cr.openjdk.java.net/~jjg/8193512/webrev.00/
>
> -- Jon

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193512: remove remnants of javah from jdk/jdk10 repo

Tim Bell
In reply to this post by Jonathan Gibbons
Jon:

> Please review these changes to remove the remnants of javah (and in a
> couple of tests, some remnants of apt and an earlier version of javap)
> from the repo, now that the tool itself has been removed.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8193512
> Webrev: http://cr.openjdk.java.net/~jjg/8193512/webrev.00/

Looks good.

Tim


Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193512: remove remnants of javah from jdk/jdk10 repo

Erik Joelsson
In reply to this post by Jonathan Gibbons
Looks good, but please use an actual autoconf 2.69 to generate the
configure scripts (see private email).

/Erik


On 2017-12-19 22:52, Jonathan Gibbons wrote:
> Please review these changes to remove the remnants of javah (and in a
> couple of tests, some remnants of apt and an earlier version of javap)
> from the repo, now that the tool itself has been removed.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8193512
> Webrev: http://cr.openjdk.java.net/~jjg/8193512/webrev.00/
>
> -- Jon

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8193512: remove remnants of javah from jdk/jdk10 repo

Alan Bateman
In reply to this post by Jonathan Gibbons


On 19/12/2017 21:52, Jonathan Gibbons wrote:
> Please review these changes to remove the remnants of javah (and in a
> couple of tests, some remnants of apt and an earlier version of javap)
> from the repo, now that the tool itself has been removed.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8193512
> Webrev: http://cr.openjdk.java.net/~jjg/8193512/webrev.00/
Looks good (and amusing to see file paths to long-removed `apt` going away).

-Alan