RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

Jiangli Zhou
Please review the change for JEP 341 (Default CDS Archives) sub-task,
JDK-8210592.

Currently, there are sub-sets of tiered tests running in CDS mode
(defined in closed tier5 and tier6 test definitions). These tests are
also executed in 'normal' mode in various tiers. GENERATE_CDS_ARCHIVE is
used to create a CDS archive using the default classlist before
executing those tests in CDS-mode.

When the default CDS archive is enabled, it is no longer necessary to
execute those tests in CDS mode explicitly since all tiered testing
enables the default CDS archive by default. The change in the webrev
removes GENERATE_CDS_ARCHIVE. To increase test coverage, the test sets
in CDS mode are converted to run in non-CDS mode (with -Xshare:off
enabled explicitly) in tier5 and tier6. The conversion is done in the
closed repo.

   webrev: http://cr.openjdk.java.net/~jiangli/8210592/webrev.00/

   JEP sub-task: https://bugs.openjdk.java.net/browse/JDK-8210592

Tested tier5 and tier6 with the default CDS archive patch enabled.

Thanks,

Jiangli

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

Mikhailo Seledtsov
Change looks good,

Misha


On 09/17/2018 03:15 PM, Jiangli Zhou wrote:

> Please review the change for JEP 341 (Default CDS Archives) sub-task,
> JDK-8210592.
>
> Currently, there are sub-sets of tiered tests running in CDS mode
> (defined in closed tier5 and tier6 test definitions). These tests are
> also executed in 'normal' mode in various tiers. GENERATE_CDS_ARCHIVE
> is used to create a CDS archive using the default classlist before
> executing those tests in CDS-mode.
>
> When the default CDS archive is enabled, it is no longer necessary to
> execute those tests in CDS mode explicitly since all tiered testing
> enables the default CDS archive by default. The change in the webrev
> removes GENERATE_CDS_ARCHIVE. To increase test coverage, the test sets
> in CDS mode are converted to run in non-CDS mode (with -Xshare:off
> enabled explicitly) in tier5 and tier6. The conversion is done in the
> closed repo.
>
>   webrev: http://cr.openjdk.java.net/~jiangli/8210592/webrev.00/
>
>   JEP sub-task: https://bugs.openjdk.java.net/browse/JDK-8210592
>
> Tested tier5 and tier6 with the default CDS archive patch enabled.
>
> Thanks,
>
> Jiangli
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

Jiangli Zhou
Thanks, Misha!

Jiangli

> On Sep 17, 2018, at 4:17 PM, mikhailo <[hidden email]> wrote:
>
> Change looks good,
>
> Misha
>
>
>> On 09/17/2018 03:15 PM, Jiangli Zhou wrote:
>> Please review the change for JEP 341 (Default CDS Archives) sub-task, JDK-8210592.
>>
>> Currently, there are sub-sets of tiered tests running in CDS mode (defined in closed tier5 and tier6 test definitions). These tests are also executed in 'normal' mode in various tiers. GENERATE_CDS_ARCHIVE is used to create a CDS archive using the default classlist before executing those tests in CDS-mode.
>>
>> When the default CDS archive is enabled, it is no longer necessary to execute those tests in CDS mode explicitly since all tiered testing enables the default CDS archive by default. The change in the webrev removes GENERATE_CDS_ARCHIVE. To increase test coverage, the test sets in CDS mode are converted to run in non-CDS mode (with -Xshare:off enabled explicitly) in tier5 and tier6. The conversion is done in the closed repo.
>>
>>   webrev: http://cr.openjdk.java.net/~jiangli/8210592/webrev.00/
>>
>>   JEP sub-task: https://bugs.openjdk.java.net/browse/JDK-8210592
>>
>> Tested tier5 and tier6 with the default CDS archive patch enabled.
>>
>> Thanks,
>>
>> Jiangli
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

Erik Joelsson
In reply to this post by Jiangli Zhou
Looks good.

/Erik


On 2018-09-17 15:15, Jiangli Zhou wrote:

> Please review the change for JEP 341 (Default CDS Archives) sub-task,
> JDK-8210592.
>
> Currently, there are sub-sets of tiered tests running in CDS mode
> (defined in closed tier5 and tier6 test definitions). These tests are
> also executed in 'normal' mode in various tiers. GENERATE_CDS_ARCHIVE
> is used to create a CDS archive using the default classlist before
> executing those tests in CDS-mode.
>
> When the default CDS archive is enabled, it is no longer necessary to
> execute those tests in CDS mode explicitly since all tiered testing
> enables the default CDS archive by default. The change in the webrev
> removes GENERATE_CDS_ARCHIVE. To increase test coverage, the test sets
> in CDS mode are converted to run in non-CDS mode (with -Xshare:off
> enabled explicitly) in tier5 and tier6. The conversion is done in the
> closed repo.
>
>   webrev: http://cr.openjdk.java.net/~jiangli/8210592/webrev.00/
>
>   JEP sub-task: https://bugs.openjdk.java.net/browse/JDK-8210592
>
> Tested tier5 and tier6 with the default CDS archive patch enabled.
>
> Thanks,
>
> Jiangli
>

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

David Holmes
In reply to this post by Jiangli Zhou
Hi Jiangli,

Conversion looks good.

Thanks,
David

On 18/09/2018 8:15 AM, Jiangli Zhou wrote:

> Please review the change for JEP 341 (Default CDS Archives) sub-task,
> JDK-8210592.
>
> Currently, there are sub-sets of tiered tests running in CDS mode
> (defined in closed tier5 and tier6 test definitions). These tests are
> also executed in 'normal' mode in various tiers. GENERATE_CDS_ARCHIVE is
> used to create a CDS archive using the default classlist before
> executing those tests in CDS-mode.
>
> When the default CDS archive is enabled, it is no longer necessary to
> execute those tests in CDS mode explicitly since all tiered testing
> enables the default CDS archive by default. The change in the webrev
> removes GENERATE_CDS_ARCHIVE. To increase test coverage, the test sets
> in CDS mode are converted to run in non-CDS mode (with -Xshare:off
> enabled explicitly) in tier5 and tier6. The conversion is done in the
> closed repo.
>
>    webrev: http://cr.openjdk.java.net/~jiangli/8210592/webrev.00/
>
>    JEP sub-task: https://bugs.openjdk.java.net/browse/JDK-8210592
>
> Tested tier5 and tier6 with the default CDS archive patch enabled.
>
> Thanks,
>
> Jiangli
>
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8210592: Convert CDS-mode test sets in tier5 and tier6 to non-CDS-mode testing

Jiangli Zhou
In reply to this post by Erik Joelsson
Thanks, Erik!

Jiangli


On 9/17/18 4:42 PM, Erik Joelsson wrote:

> Looks good.
>
> /Erik
>
>
> On 2018-09-17 15:15, Jiangli Zhou wrote:
>> Please review the change for JEP 341 (Default CDS Archives) sub-task,
>> JDK-8210592.
>>
>> Currently, there are sub-sets of tiered tests running in CDS mode
>> (defined in closed tier5 and tier6 test definitions). These tests are
>> also executed in 'normal' mode in various tiers. GENERATE_CDS_ARCHIVE
>> is used to create a CDS archive using the default classlist before
>> executing those tests in CDS-mode.
>>
>> When the default CDS archive is enabled, it is no longer necessary to
>> execute those tests in CDS mode explicitly since all tiered testing
>> enables the default CDS archive by default. The change in the webrev
>> removes GENERATE_CDS_ARCHIVE. To increase test coverage, the test
>> sets in CDS mode are converted to run in non-CDS mode (with
>> -Xshare:off enabled explicitly) in tier5 and tier6. The conversion is
>> done in the closed repo.
>>
>>   webrev: http://cr.openjdk.java.net/~jiangli/8210592/webrev.00/
>>
>>   JEP sub-task: https://bugs.openjdk.java.net/browse/JDK-8210592
>>
>> Tested tier5 and tier6 with the default CDS archive patch enabled.
>>
>> Thanks,
>>
>> Jiangli
>>
>