RFR: JDK-8227693: HTML error in jdwp-protocol.html

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8227693: HTML error in jdwp-protocol.html

Alex Menkov-2
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8227693: HTML error in jdwp-protocol.html

Daniel D. Daugherty
On 7/19/19 6:56 PM, Alex Menkov wrote:
> Hi all,
>
> please review tiny fix for generated jdwp-protocol.html
> One of the recent fixes added H1 element with incorrect id attribute
> value.
>
> jira: https://bugs.openjdk.java.net/browse/JDK-8227693
> webrev:
> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_space_id/webrev/

make/jdk/src/classes/build/tools/jdwpgen/RootNode.java
     No comments.

Thumbs up. This qualifies as a trivial fix so only a single
reviewer is needed and no need to wait 24 hours.

Dan


>
> generated docs:
> old:
> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_space_id/0/jdwp-protocol.html
> new:
> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_space_id/1/jdwp-protocol.html
>
> --alex

Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8227693: HTML error in jdwp-protocol.html

serguei.spitsyn@oracle.com
+1

Thanks,
Serguei


On 7/20/19 05:44, Daniel D. Daugherty wrote:

> On 7/19/19 6:56 PM, Alex Menkov wrote:
>> Hi all,
>>
>> please review tiny fix for generated jdwp-protocol.html
>> One of the recent fixes added H1 element with incorrect id attribute
>> value.
>>
>> jira: https://bugs.openjdk.java.net/browse/JDK-8227693
>> webrev:
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_space_id/webrev/
>
> make/jdk/src/classes/build/tools/jdwpgen/RootNode.java
>     No comments.
>
> Thumbs up. This qualifies as a trivial fix so only a single
> reviewer is needed and no need to wait 24 hours.
>
> Dan
>
>
>>
>> generated docs:
>> old:
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_space_id/0/jdwp-protocol.html
>> new:
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_space_id/1/jdwp-protocol.html
>>
>> --alex
>