RFR: JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522

Andrey Vershinin
This is a simple change removing disabling of MSVC++ warning 4522. Since it only affects build process, no tests were ran.

-------------

Commit messages:
 - 8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522

Changes: https://git.openjdk.java.net/jdk/pull/2646/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2646&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8254239
  Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2646.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2646/head:pull/2646

PR: https://git.openjdk.java.net/jdk/pull/2646
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.

Ioi Lam-2
On Fri, 19 Feb 2021 15:05:24 GMT, Andrey Vershinin <[hidden email]> wrote:

> This is a simple change removing disabling of MSVC++ warning 4522. Since it only affects build process, no tests were ran.

Pre-submit test was skipped because:

> Testing is not configured
> In order to run pre-submit tests, the source repository must be properly configured to allow test execution. See https://wiki.openjdk.java.net/display/SKARA/Testing for more information on how to configure this.

Since this is a build change, please enable pre-submit testing to make sure it doesn't break anything.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2646
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.

Andrey Vershinin
On Fri, 19 Feb 2021 17:19:15 GMT, Ioi Lam <[hidden email]> wrote:

>> This is a simple change removing disabling of MSVC++ warning 4522. Since it only affects build process, no tests were ran.
>
> Pre-submit test was skipped because:
>
>> Testing is not configured
>> In order to run pre-submit tests, the source repository must be properly configured to allow test execution. See https://wiki.openjdk.java.net/display/SKARA/Testing for more information on how to configure this.
>
> Since this is a build change, please enable pre-submit testing to make sure it doesn't break anything.

@iklam Thanks for the notice, the tests have passed now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2646
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.

Ioi Lam-2
In reply to this post by Andrey Vershinin
On Fri, 19 Feb 2021 15:05:24 GMT, Andrey Vershinin <[hidden email]> wrote:

> This is a simple change removing disabling of MSVC++ warning 4522. Since it only affects build process, no tests were ran.

Marked as reviewed by iklam (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2646
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.

Kim Barrett-2
In reply to this post by Andrey Vershinin
On Fri, 19 Feb 2021 15:05:24 GMT, Andrey Vershinin <[hidden email]> wrote:

> This is a simple change removing disabling of MSVC++ warning 4522. Since it only affects build process, no tests were ran.

Marked as reviewed by kbarrett (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2646
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.

Andrey Vershinin
In reply to this post by Andrey Vershinin
On Fri, 19 Feb 2021 15:05:24 GMT, Andrey Vershinin <[hidden email]> wrote:

> This is a simple change removing disabling of MSVC++ warning 4522. Since it only affects build process, no tests were ran.

This pull request has now been integrated.

Changeset: 26c1db90
Author:    Andrey Vershinin <[hidden email]>
Committer: Kim Barrett <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/26c1db90
Stats:     6 lines in 1 file changed: 0 ins; 6 del; 0 mod

8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.

Reviewed-by: iklam, kbarrett

-------------

PR: https://git.openjdk.java.net/jdk/pull/2646