RFR: JDK-8258655: remove <-- NewPage --> comment from generated pages

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RFR: JDK-8258655: remove <-- NewPage --> comment from generated pages

Jonathan Gibbons-2
Small change to remove an unnecessary comment from the beginning of generated files.  I'm guessing the comment dates from way back when the doc pages were used to generate paper books.  For those that want to identify that point in the file, either the DOCTYPE or start of the HTML elements t should be enough.

No test: it's somewhat silly to rigorously test that the comment will always be missing.

-------------

Commit messages:
 - JDK-8258655: remove <-- NewPage --> comment from generated pages

Changes: https://git.openjdk.java.net/jdk/pull/1833/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1833&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8258655
  Stats: 25 lines in 5 files changed: 0 ins; 18 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1833.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1833/head:pull/1833

PR: https://git.openjdk.java.net/jdk/pull/1833
Reply | Threaded
Open this post in threaded view
|

Re: RFR: JDK-8258655: remove <-- NewPage --> comment from generated pages

Hannes Wallnöfer
On Fri, 18 Dec 2020 01:16:41 GMT, Jonathan Gibbons <[hidden email]> wrote:

> Small change to remove an unnecessary comment from the beginning of generated files.  I'm guessing the comment dates from way back when the doc pages were used to generate paper books.  For those that want to identify that point in the file, either the DOCTYPE or start of the HTML elements t should be enough.
>
> No test: it's somewhat silly to rigorously test that the comment will always be missing.

Looks good!

-------------

Marked as reviewed by hannesw (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1833
Reply | Threaded
Open this post in threaded view
|

Integrated: JDK-8258655: remove <-- NewPage --> comment from generated pages

Jonathan Gibbons-2
In reply to this post by Jonathan Gibbons-2
On Fri, 18 Dec 2020 01:16:41 GMT, Jonathan Gibbons <[hidden email]> wrote:

> Small change to remove an unnecessary comment from the beginning of generated files.  I'm guessing the comment dates from way back when the doc pages were used to generate paper books.  For those that want to identify that point in the file, either the DOCTYPE or start of the HTML elements should be enough.
>
> No test: it's somewhat silly to rigorously test that the comment will always be missing.

This pull request has now been integrated.

Changeset: d9f21346
Author:    Jonathan Gibbons <[hidden email]>
URL:       https://git.openjdk.java.net/jdk/commit/d9f21346
Stats:     25 lines in 5 files changed: 0 ins; 18 del; 7 mod

8258655: remove <-- NewPage --> comment from generated pages

Reviewed-by: hannesw

-------------

PR: https://git.openjdk.java.net/jdk/pull/1833